Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #54859

Merged
merged 38 commits into from
Oct 6, 2018
Merged

Rollup of 11 pull requests #54859

merged 38 commits into from
Oct 6, 2018

Commits on Sep 27, 2018

  1. Expand the documentation for the std::sync module

    Provides an overview on why synchronization is required,
    as well a short summary of what sync primitives are available.
    GabrielMajeri committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    f5e991b View commit details
    Browse the repository at this point in the history
  2. Make example code use global variables

    Because `fn main()` was added automatically, the variables
    were actually local statics.
    GabrielMajeri committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    e0df0ae View commit details
    Browse the repository at this point in the history
  3. Address review comments

    Reword the lead paragraph and turn the list items into
    complete sentences.
    GabrielMajeri committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    f3fdbbf View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2018

  1. Fix broken links

    GabrielMajeri committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    bcec6bb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e921aa View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2018

  1. Configuration menu
    Copy the full SHA
    4d58821 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    113141b View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2018

  1. Configuration menu
    Copy the full SHA
    594655b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea3d8f5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    769b383 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2018

  1. rustdoc: overflow:auto doesn't work nicely on small screens

    This property was introduced by 3f92ff3, but looks it doesn't
    overwrap even without the property.
    
    Fixes rust-lang#54672.
    kzys committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    2feea63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ba5584 View commit details
    Browse the repository at this point in the history
  3. rustc/ty: whitespace fixes

    ljedrz committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    2ff117d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    91fc573 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    029e261 View commit details
    Browse the repository at this point in the history
  6. rustc/ty: improve allocations

    ljedrz committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    e153103 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0ee6b54 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7ad21a8 View commit details
    Browse the repository at this point in the history
  9. contast -> contrast

    11Takanori committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    819cbfe View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9da428d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f5db411 View commit details
    Browse the repository at this point in the history
  12. Revert "Add another assert"

    This reverts commit 21d2a6c.
    alexcrichton committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    8d81c03 View commit details
    Browse the repository at this point in the history
  13. Revert "Fix tidy"

    This reverts commit 1908892.
    alexcrichton committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    5444148 View commit details
    Browse the repository at this point in the history
  14. Revert "Add docs and debug asserts"

    This reverts commit 1a1a7f6.
    alexcrichton committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    9a41cfa View commit details
    Browse the repository at this point in the history
  15. Revert "Optimize VecDeque::append"

    This reverts commit 11e488b.
    alexcrichton committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    90b9469 View commit details
    Browse the repository at this point in the history
  16. Revert "Slightly refactor VecDeque implementation"

    This reverts commit 6ce76ac.
    alexcrichton committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    70ae43f View commit details
    Browse the repository at this point in the history
  17. Simplify test.

    Removes unnecessary type mismatch error from test that was hiding
    borrow check error from NLL stderr.
    davidtwco committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    c07b712 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#54078 - GabrielMajeri:expand-sync-docs, r=s…

    …teveklabnik
    
    Expand the documentation for the `std::sync` module
    
    I've tried to expand the documentation for Rust's synchronization primitives. The module level documentation explains why synchronization is required when working with a multiprocessor system,
    and then links to the appropiate structure in this module.
    
    Fixes rust-lang#29377, since this should be the last item on the checklist (documentation for `Atomic*` was fixed in rust-lang#44854, but not ticked off the checklist).
    pietroalbini authored Oct 5, 2018
    Configuration menu
    Copy the full SHA
    6b24de1 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#54717 - ljedrz:cleanup_ty_p1, r=davidtwco

    Cleanup rustc/ty part 1
    
    Part 2 will follow soon; I wouldn't want these changes to rot too quickly.
    
    - improve stack shifting and remove related allocations
    - move a faster early return up
    - improve allocations
    - use Cow<str> where applicable
    - simplify common patterns
    - whitespace fixes
    pietroalbini authored Oct 5, 2018
    Configuration menu
    Copy the full SHA
    5efac03 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#54781 - phansch:master, r=varkor

    Add examples to `TyKind::FnDef` and `TyKind::FnPtr` docs
    
    This adds two examples to the docs of `TyKind::FnDef` and `TyKind::FnPtr`.
    
    I found these two types a bit confusing when I learned about them and I think adding these examples might help others.
    pietroalbini authored Oct 5, 2018
    Configuration menu
    Copy the full SHA
    9e8f522 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#54787 - varkor:unused-mut-in-desugaring, r=…

    …nikomatsakis
    
    Only warn about unused `mut` in user-written code
    
    Fixes rust-lang#54586.
    
    r? @pnkfelix
    cc @blitzerr
    pietroalbini authored Oct 5, 2018
    Configuration menu
    Copy the full SHA
    3810657 View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#54804 - euclio:inverted-parameters, r=estebank

    add suggestion for inverted function parameters
    
    Fixes rust-lang#54065.
    pietroalbini authored Oct 5, 2018
    Configuration menu
    Copy the full SHA
    ee745d6 View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#54812 - pnkfelix:issue-32382-index-assoc-ty…

    …pe-with-lifetime, r=nikomatsakis
    
    Regression test for rust-lang#32382.
    pietroalbini authored Oct 5, 2018
    Configuration menu
    Copy the full SHA
    08af25f View commit details
    Browse the repository at this point in the history
  24. Rollup merge of rust-lang#54833 - abonander:issue-54441, r=petrochenkov

    make `Parser::parse_foreign_item()` return a foreign item or error
    
    Fixes `Parser::parse_foreign_item()` to follow the convention of `parse_trait_item()` and `parse_impl_item()` in that it *must* parse an item or return an error, and then the caller is responsible for detecting the closing delimiter.
    
    This prevents it from looping endlessly on an unexpected token in `ext/expand.rs` where it was also leaking memory by continually pushing to `Parser::expected_tokens` via `Parser::check_keyword()`.
    
    closes rust-lang#54441
    
    r? @petrochenkov
    cc @dtolnay
    pietroalbini authored Oct 5, 2018
    Configuration menu
    Copy the full SHA
    a95a6e2 View commit details
    Browse the repository at this point in the history
  25. Rollup merge of rust-lang#54834 - kzys:fix-small-screen, r=GuillaumeG…

    …omez
    
    rustdoc: overflow:auto doesn't work nicely on small screens
    
    This property was introduced by 3f92ff3, but looks it doesn't
    overwrap even without the property.
    
    Fixes rust-lang#54672.
    pietroalbini authored Oct 5, 2018
    Configuration menu
    Copy the full SHA
    f1b42c5 View commit details
    Browse the repository at this point in the history
  26. Rollup merge of rust-lang#54838 - 11Takanori:fix-typo, r=petrochenkov

    Fix typo in src/libsyntax/parse/parser.rs
    
    contast -> contrast
    pietroalbini authored Oct 5, 2018
    Configuration menu
    Copy the full SHA
    42fcde8 View commit details
    Browse the repository at this point in the history
  27. Rollup merge of rust-lang#54851 - alexcrichton:revert-optimize, r=sfa…

    …ckler
    
    Fix a regression in 1.30 by reverting rust-lang#53564
    
    Investigation on rust-lang#54477 revealed rust-lang#53564 as the culprit in the regression for that crate. I've reproduced the regression with the [detailed test cases provided](rust-lang#54477 (comment)). While we figure out how to fix the regression this commit reverts the current culprit.
    pietroalbini authored Oct 5, 2018
    Configuration menu
    Copy the full SHA
    402c699 View commit details
    Browse the repository at this point in the history
  28. Rollup merge of rust-lang#54853 - davidtwco:issue-52663-missing-lifet…

    …ime-suggestion-test, r=nikomatsakis
    
    Remove unneccessary error from test, revealing NLL error.
    
    Part of rust-lang#52663.
    
    Removes unnecessary type mismatch error from test that was hiding
    borrow check error from NLL stderr.
    
    r? @nikomatsakis
    pietroalbini authored Oct 5, 2018
    Configuration menu
    Copy the full SHA
    51334c9 View commit details
    Browse the repository at this point in the history