Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Delete grouping logic from the musl target #55659

Merged
merged 1 commit into from
Nov 9, 2018

Commits on Nov 3, 2018

  1. rustc: Delete grouping logic from the musl target

    This commit deletes the injection of `-(` and `-)` options to the linker
    for the musl targets. This actually causes problems today on nightly if
    you execute:
    
        $ echo 'fn main() {}' >> foo.rs
        $ rustc --target x86_64-unknown-linux-musl -C panic=abort
    
    you get a linker error about "cannot nest groups". This comes about
    because rustc injects its own `--start-group` and `--end-group`
    variables which clash with the outer `-(` and `-)` variables. It's not
    entirely clear to me why this doesn't affect the musl target by default
    (in `-C panic=unwind` mode).
    
    The compiler's own injection of `--start-group` and `--end-group` should
    solve the issues mentioned in the comment for injecting `-(` and `-)` as
    well.
    alexcrichton committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    f3428a7 View commit details
    Browse the repository at this point in the history