Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.30.1 stable release #55738

Merged
merged 8 commits into from
Nov 7, 2018
Merged

1.30.1 stable release #55738

merged 8 commits into from
Nov 7, 2018

Commits on Nov 7, 2018

  1. Fix link to macros chapter 

    We're gonna link to nightly as this didn't make it into the corresponding stable.
    @steveklabnik @Mark-Simulacrum
    steveklabnik authored and Mark-Simulacrum committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    0d442ec View commit details
    Browse the repository at this point in the history

  2. Update RELEASES.md 

    Co-Authored-By: steveklabnik <[email protected]>
    @frewsxcv @steveklabnik @Mark-Simulacrum
    2 people authored and Mark-Simulacrum committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    66158c1 View commit details
    Browse the repository at this point in the history

  3. Auto merge of rust-lang#54199 - nikomatsakis:predicate_may_hold-failu… 

    …re, r=eddyb

overlook overflows in rustdoc trait solving

Context:

The new rustdoc "auto trait" feature walks across impls and tries to run trait solving on them with a lot of unconstrained variables. This is prone to overflows. These overflows used to cause an ICE because of a caching bug (fixed in this PR). But even once that is fixed, it means that rustdoc causes an overflow rather than generating docs.

This PR therefore adds a new helper that propagates the overflow error out. This requires rustdoc to then decide what to do when it encounters such an overflow: technically, an overflow represents neither "yes" nor "no", but rather a failure to make a decision. I've decided to opt on the side of treating this as "yes, implemented", since rustdoc already takes an optimistic view. This may prove to include too many items, but I *suspect* not.

We could probably reduce the rate of overflows by unifying more of the parameters from the impl -- right now we only seem to consider the self type. Moreover, in the future, as we transition to Chalk, overflow errors are expected to just "go away" (in some cases, though, queries might return an ambiguous result).

Fixes rust-lang#52873

cc @QuietMisdreavus -- this is the stuff we were talking about earlier
cc @GuillaumeGomez -- this supersedes rust-lang#53687
    @bors @Mark-Simulacrum
    bors authored and Mark-Simulacrum committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    6209276 View commit details
    Browse the repository at this point in the history

  4. Auto merge of rust-lang#55362 - ehuss:releases-cargo-new-edition, r=M… 

    …ark-Simulacrum

Remove `cargo new --edition` from release notes.

This was removed at the last minute (rust-lang#55315, rust-lang/cargo#6216).
Apologies for not catching this.
    @bors @Mark-Simulacrum
    bors authored and Mark-Simulacrum committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    d6cd7bb View commit details
    Browse the repository at this point in the history

  5. Bubble up an overflow error so that rustdoc can ignore it

    @oli-obk @Mark-Simulacrum
    oli-obk authored and Mark-Simulacrum committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    441d862 View commit details
    Browse the repository at this point in the history

  6. Update cargo to tip

    @Mark-Simulacrum
    Mark-Simulacrum committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    5eb1eb7 View commit details
    Browse the repository at this point in the history

  7. Include changes from 1.30.1 in release notes

    @Mark-Simulacrum
    Mark-Simulacrum committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    83b2de1 View commit details
    Browse the repository at this point in the history

  8. Bump to 1.30.1 release

    @Mark-Simulacrum
    Mark-Simulacrum committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    59e6ce4 View commit details
    Browse the repository at this point in the history