Improve creation of 3 IndexVecs #55755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
varkor
reviewed
Nov 8, 2018
ljedrz
force-pushed
the
a_few_indexvec_tweaks
branch
from
5811012
to
e3390d8
Compare
|
@bors r+ rollup |
|
📌 Commit e3390d8 has been approved by |
bors
added
S-waiting-on-bors
pnkfelix
reviewed
Nov 8, 2018
| @@ -196,7 +196,7 @@ fn build_drop_shim<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, | |||
| let source_info = SourceInfo { span, scope: OUTERMOST_SOURCE_SCOPE }; | |||
|
|
|||
| let return_block = BasicBlock::new(1); | |||
| let mut blocks = IndexVec::new(); | |||
| let mut blocks = IndexVec::with_capacity(2); | |||
There was a problem hiding this comment.
hmm do we want/need a SmallIndexVec that is analogous to SmallVec ...?
There was a problem hiding this comment.
or ... should we try something bonkers like changing IndexVec to use a SmallVec internally...?
There was a problem hiding this comment.
I could submit an experimental PR to check the perf implications.
There was a problem hiding this comment.
This is harder than I thought; changing the underlying structure of IndexVec to a SmallVec makes Mir a recursive type of infinite size due to the promoted component.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 8, 2018
Improve creation of 3 IndexVecs - preallocate when the minimal size is known - use `from_elem_n` instead of `new`+`resize`
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Nov 9, 2018
Improve creation of 3 IndexVecs - preallocate when the minimal size is known - use `from_elem_n` instead of `new`+`resize`
bors
added a commit
that referenced
this pull request
Nov 9, 2018
Rollup of 17 pull requests Successful merges: - #55576 (Clarify error message for -C opt-level) - #55633 (Support memcpy/memmove with differing src/dst alignment) - #55638 (Fix ICE in msg_span_from_free_region on ReEmpty) - #55659 (rustc: Delete grouping logic from the musl target) - #55719 (Sidestep link error from rustfix'ed code by using a *defined* static.) - #55736 (Elide anon lifetimes in conflicting impl note) - #55739 (Consume optimization fuel from the MIR inliner) - #55742 (Avoid panic when matching function call) - #55753 (borrow_set: remove a helper function and a clone it uses) - #55755 (Improve creation of 3 IndexVecs) - #55758 ([regression - rust2018]: unused_mut lint false positives on nightly) - #55760 (Remove intermediate font specs) - #55761 (mir: remove a hacky recursive helper function) - #55774 (wasm32-unknown-emscripten expects the rust_eh_personality symbol) - #55777 (Use `Lit` rather than `P<Lit>` in `ast::ExprKind`.) - #55783 (Deprecate mpsc channel selection) - #55788 (rustc: Request ansi colors if stderr isn't a tty) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_elem_ninstead ofnew+resize