Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miri engine refactoring #55915

Merged
merged 34 commits into from
Nov 25, 2018
Merged

Miri engine refactoring #55915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
98cd2ad
Move some methods from `Memory` to `Allocation`
oli-obk Nov 12, 2018
d40a771
Preliminary code adjustment to let the compiler complain about missin…
oli-obk Nov 12, 2018
eb30ce8
Move relocation methods from `Memory` to `Allocation`
oli-obk Nov 12, 2018
d98c46c
Move undef mask methods from `Memory` to `Allocation`
oli-obk Nov 12, 2018
7c9d786
Move alignment and bounds check from `Memory` to `Allocation`
oli-obk Nov 12, 2018
c392fbb
Adjust generics to `Allocation` parameters
oli-obk Nov 12, 2018
04210f3
Access `self` instead of `alloc`
oli-obk Nov 12, 2018
ad11856
Fiddle a `HasDataLayout` through the allocation methods
oli-obk Nov 12, 2018
9ecde57
Move some byte and scalar accessors from `Memory` to `Allocation`
oli-obk Nov 12, 2018
07e7804
Adjust rustc_mir::interpret to changes in `Allocation`/`Memory` methods
oli-obk Nov 12, 2018
3a0e825
Remove unnecessary `Result` (function always returned `Ok`)
oli-obk Nov 13, 2018
a835555
Make zst accesses in allocations take the regular path.
oli-obk Nov 13, 2018
df1ed0c
Make a method that doesn't need `Self` a free function instead
oli-obk Nov 13, 2018
20dee47
Add regression test for integral pointers in zst str slice fat pointers
oli-obk Nov 13, 2018
cc2f46e
Reorder methods in `allocation.rs`
oli-obk Nov 13, 2018
ebf0336
Properly test for int pointers in fat pointers to str slices of zero …
oli-obk Nov 13, 2018
ef33295
Reintroduce zst-slice reading `read_bytes` method on `Memory`
oli-obk Nov 13, 2018
87bd5d1
Remove stderr file, because the test passes now
oli-obk Nov 13, 2018
65b702c
Update miri submodule
oli-obk Nov 14, 2018
b820cc7
Clean up array/slice of primitive validation
oli-obk Nov 14, 2018
d3139b9
Rebase fallout
oli-obk Nov 14, 2018
1c08ced
Explain early abort legality
oli-obk Nov 14, 2018
8b04b09
Move alignment checks out of `Allocation`
oli-obk Nov 15, 2018
9d57adf
Explain {read,write}_scalar failure to cope with zsts
oli-obk Nov 15, 2018
927c5aa
Use correct alignment for fat pointer extra part
oli-obk Nov 15, 2018
9b8e82a
Use correct alignment checks for scalars and zsts, too
oli-obk Nov 15, 2018
10102d1
comment nit
RalfJung Nov 16, 2018
a5ef2d1
Array and slice projections need to update the place alignment
oli-obk Nov 16, 2018
cb8fa33
tidy
oli-obk Nov 16, 2018
972d798
Document `Allocation`
oli-obk Nov 16, 2018
2287219
Factor out mplace offsetting into its own method
oli-obk Nov 17, 2018
3220c0c
Explain why vtable generation needs no alignment checks
oli-obk Nov 17, 2018
360f988
update miri submodule
oli-obk Nov 17, 2018
b853252
Rebase fallout
oli-obk Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Cargo.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ dependencies = [
"clippy-mini-macro-test 0.2.0",
"clippy_dev 0.0.1",
"clippy_lints 0.0.212",
"compiletest_rs 0.3.16 (registry+https://github.com/rust-lang/crates.io-index)",
"compiletest_rs 0.3.17 (registry+https://github.com/rust-lang/crates.io-index)",
"derive-new 0.5.4 (registry+https://github.com/rust-lang/crates.io-index)",
"lazy_static 1.1.0 (registry+https://github.com/rust-lang/crates.io-index)",
"regex 1.0.4 (registry+https://github.com/rust-lang/crates.io-index)",
Expand Down Expand Up @@ -423,7 +423,7 @@ dependencies = [

[[package]]
name = "compiletest_rs"
version = "0.3.16"
version = "0.3.17"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [
"diff 0.1.11 (registry+https://github.com/rust-lang/crates.io-index)",
Expand Down Expand Up @@ -1315,7 +1315,7 @@ dependencies = [
"byteorder 1.2.3 (registry+https://github.com/rust-lang/crates.io-index)",
"cargo_metadata 0.6.2 (registry+https://github.com/rust-lang/crates.io-index)",
"colored 1.6.0 (registry+https://github.com/rust-lang/crates.io-index)",
"compiletest_rs 0.3.16 (registry+https://github.com/rust-lang/crates.io-index)",
"compiletest_rs 0.3.17 (registry+https://github.com/rust-lang/crates.io-index)",
"env_logger 0.5.12 (registry+https://github.com/rust-lang/crates.io-index)",
"log 0.4.5 (registry+https://github.com/rust-lang/crates.io-index)",
"vergen 3.0.3 (registry+https://github.com/rust-lang/crates.io-index)",
Expand Down Expand Up @@ -3274,7 +3274,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
"checksum colored 1.6.0 (registry+https://github.com/rust-lang/crates.io-index)" = "b0aa3473e85a3161b59845d6096b289bb577874cafeaf75ea1b1beaa6572c7fc"
"checksum commoncrypto 0.2.0 (registry+https://github.com/rust-lang/crates.io-index)" = "d056a8586ba25a1e4d61cb090900e495952c7886786fc55f909ab2f819b69007"
"checksum commoncrypto-sys 0.2.0 (registry+https://github.com/rust-lang/crates.io-index)" = "1fed34f46747aa73dfaa578069fd8279d2818ade2b55f38f22a9401c7f4083e2"
"checksum compiletest_rs 0.3.16 (registry+https://github.com/rust-lang/crates.io-index)" = "75e809f56d6aa9575b67924b0af686c4f4c1380314f47947e235e9ff7fa94bed"
"checksum compiletest_rs 0.3.17 (registry+https://github.com/rust-lang/crates.io-index)" = "89747fe073b7838343bd2c2445e7a7c2e0d415598f8925f0fa9205b9cdfc48cb"
"checksum core-foundation 0.6.1 (registry+https://github.com/rust-lang/crates.io-index)" = "cc3532ec724375c7cb7ff0a097b714fde180bb1f6ed2ab27cfcd99ffca873cd2"
"checksum core-foundation-sys 0.6.1 (registry+https://github.com/rust-lang/crates.io-index)" = "a3fb15cdbdd9cf8b82d97d0296bb5cd3631bba58d6e31650a002a8e7fb5721f9"
"checksum crossbeam 0.3.2 (registry+https://github.com/rust-lang/crates.io-index)" = "24ce9782d4d5c53674646a6a4c1863a21a8fc0cb649b3c94dfc16e45071dea19"
Expand Down
Loading