Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: Fix issues with compiler docs #56441

Merged
merged 1 commit into from
Dec 6, 2018
Merged

rustbuild: Fix issues with compiler docs #56441

merged 1 commit into from
Dec 6, 2018

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Dec 2, 2018

@ollie27
rustbuild: Fix issues with compiler docs
3b705a0 
* Create output directories for crates beforehand so rustdoc uses relative links
* Readd rustc_codegen_ssa
* Don't build out of tree dependencies for rustdoc like we don't for rustc
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 2, 2018
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 3, 2018

📌 Commit 3b705a0 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Dec 4, 2018
@kennytm
Rollup merge of rust-lang#56441 - ollie27:rustbuild_compiler_docs, r=…
3dfaeab 
…alexcrichton

rustbuild: Fix issues with compiler docs

* Create output directories for crates beforehand so rustdoc uses relative links (fixes rust-lang#56107)
* Readd rustc_codegen_ssa (fixes rust-lang#56196)
* Don't build out of tree dependencies for rustdoc like we don't for rustc
@kennytm kennytm mentioned this pull request Dec 4, 2018
Closed
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 5, 2018
Closed
kennytm added a commit to GuillaumeGomez/rust that referenced this pull request Dec 5, 2018
@kennytm
Rollup merge of rust-lang#56441 - ollie27:rustbuild_compiler_docs, r=…
096c434 
…alexcrichton

rustbuild: Fix issues with compiler docs

* Create output directories for crates beforehand so rustdoc uses relative links (fixes rust-lang#56107)
* Readd rustc_codegen_ssa (fixes rust-lang#56196)
* Don't build out of tree dependencies for rustdoc like we don't for rustc
@pietroalbini
Copy link
Member

Probably caused the rollup #56531 to fail?

@bors r-

Please reapprove if this didn't cause the failure :)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 5, 2018
@ollie27
Copy link
Member Author

ollie27 commented Dec 5, 2018

It looks like it was actually #56010 (comment).

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Dec 5, 2018

📌 Commit 3b705a0 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 5, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Dec 6, 2018
@pietroalbini
Rollup merge of rust-lang#56441 - ollie27:rustbuild_compiler_docs, r=…
0be8537 
…alexcrichton

rustbuild: Fix issues with compiler docs

* Create output directories for crates beforehand so rustdoc uses relative links (fixes rust-lang#56107)
* Readd rustc_codegen_ssa (fixes rust-lang#56196)
* Don't build out of tree dependencies for rustdoc like we don't for rustc
@pietroalbini pietroalbini mentioned this pull request Dec 6, 2018
Merged
bors added a commit that referenced this pull request Dec 6, 2018
@bors
Auto merge of #56557 - pietroalbini:rollup, r=pietroalbini
367e783 
Rollup of 11 pull requests

Successful merges:

 - #56315 (Rustdoc inline macro reexport)
 - #56332 ([rustdoc] Specific crate search)
 - #56362 (Stabilise exhaustive integer patterns)
 - #56426 (libsyntax_pos: A few tweaks)
 - #56441 (rustbuild: Fix issues with compiler docs)
 - #56446 (pass the parameter environment to `traits::find_associated_item`)
 - #56500 (cleanup: remove static lifetimes from consts)
 - #56525 (Avoid extra copy and syscall in std::env::current_exe)
 - #56528 (Remove unused dependency (rustc_lint -> rustc_mir))
 - #56548 (Optimized string FromIterator + Extend impls)
 - #56553 (Don't print the profiling summary to stdout when -Zprofile-json is set)

Failed merges:

r? @ghost
@bors bors merged commit 3b705a0 into rust-lang:master Dec 6, 2018
@ollie27 ollie27 deleted the rustbuild_compiler_docs branch December 6, 2018 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustc_codegen_ssa missing from compiler docs Broken links in compiler internal docs
5 participants
@ollie27 @rust-highfive @alexcrichton @bors @pietroalbini