Rollup of 5 pull requests #56688
Merged
Rollup of 5 pull requests #56688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emit error with span for empty asserts Fixes rust-lang#55547.
…lay, r=QuietMisdreavus Fix right arrow size for crate filter This bug only appears when a crate has a long name: <img width="1440" alt="screenshot 2018-12-08 at 16 36 21" src="https://user-images.githubusercontent.com/3050060/49687728-7de06180-fb07-11e8-8554-d32597351fac.png"> With this fix, it goes back to normal, whatever the size: <img width="1440" alt="screenshot 2018-12-08 at 16 36 05" src="https://user-images.githubusercontent.com/3050060/49687730-8769c980-fb07-11e8-91b7-b5e1961211a2.png"> r? @QuietMisdreavus
…valid-nb-parameters, r=estebank fix span for invalid number of parameters in trait method Fixes rust-lang#56582.
…Centril Fix typo
Add regression test for ICE Fixes rust-lang#55846 with a minimal (or as best as I can manage) test case. I tested this against 1.30.0 manually to confirm it crashes. The issue seemed to have something to do with associated types. It's possible someone with more knowledge can shrink the test case down further, or make it clearer.
|
@bors: r+ p=5 |
|
📌 Commit a11de41 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost