-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wf-check the output type of a function in MIR-typeck #57282
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ This seems like a good fix for now anyhow. It seems to be the equivalent of this code from the standard type-checker: rust/src/librustc_typeck/check/callee.rs Lines 71 to 72 in ec19464
One thing though -- I am having a hard time figuring out where this would occur (in the standard type-checker, I mean) for the case of methods. But still this variant of the example using methods gets an error in the standard checker, so presumably it's happening somewhere. |
📌 Commit 5dfc5f2 has been approved by |
@bors p=1 -- regression |
Nominating for beta: this is actually a stable-to-stable regression -- maybe it makes sense to backport to beta? Or maybe not worth it. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r=nikomatsakis |
📌 Commit 8ca83e9 has been approved by |
☀️ Test successful - status-appveyor, status-travis |
Discussed at the T-compiler meeting, has been accepted for a backport. |
[beta] Rollup backports Cherry-picked: * #57053: Fix alignment for array indexing * #57181: resolve: Fix another ICE in import validation * #57185: resolve: Fix one more ICE in import validation * #57282: Wf-check the output type of a function in MIR-typeck * #55318: Ensure that Rustdoc discovers all necessary auto trait bounds * #56838: Call poly_project_and_unify_type on types that contain inference types Rolled up: * #57300: [beta] Update RLS to include 100% CPU on hover bugfix * #57301: beta: bootstrap from latest stable (1.31.1) * #57292: [BETA] Update cargo r? @ghost
Closes #57265
cc @scalexm