Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 19 pull requests #57309

Closed
wants to merge 77 commits into from

Commits on Dec 24, 2018

  1. Search codegen backends based on target libdir instead of sysroot.

    Fixes cases with custom libdir when it consists of two or more parts.
    o01eg committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    4e7d53d View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2018

  1. Add closure cannot be moved note.

    This commit extends existing logic for checking whether a closure that
    is `FnOnce` and therefore moves variables that it captures from the
    environment has already been invoked when being invoked again.
    
    Now, this logic will also check whether the closure is being moved after
    previously being moved or invoked and add an appropriate note.
    davidtwco committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    fcad209 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2018

  1. Configuration menu
    Copy the full SHA
    fff905b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c118b17 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2018

  1. Configuration menu
    Copy the full SHA
    2149d73 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2018

  1. Remove unused types from rustc::mir::interpret

    The types are no longer used with the change to stacked borrows for
    validation.
    matthewjasper committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    49e52e7 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2018

  1. test: Add test for issues 45510 and 18952.

    Those tests are directly taken from the comments on the bug reports.
    cjgillot committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    4e77c3a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6de9c13 View commit details
    Browse the repository at this point in the history
  3. rustc_typeck: Implement resolution advised in issue 45510.

    When resolving Fn traits, the compiler failed to take into account
    overloaded implementations.  To resolve this, we inform the trait dispatch
    code that the arguments will becoming as a tuple of correct arity.
    cjgillot committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    1827d52 View commit details
    Browse the repository at this point in the history
  4. Move tests to ui.

    cjgillot committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    f518cf9 View commit details
    Browse the repository at this point in the history
  5. Fix failing diagnostic test.

    cjgillot committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    2f42a18 View commit details
    Browse the repository at this point in the history
  6. Add comment.

    cjgillot committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    2530ce9 View commit details
    Browse the repository at this point in the history
  7. Change return types and check return values in tests.

    This allows to verify that we handle
    different types as return types,
    and that we call the expected functions.
    cjgillot committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    91c155b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    afb7c06 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3512a72 View commit details
    Browse the repository at this point in the history
  10. Add some tests

    This copies and adjusts the existing coherence tests to ensure that
    they continue to work using the new implementation.
    weiznich committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    b8ee6fa View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e869e5f View commit details
    Browse the repository at this point in the history
  12. Fix tidy

    weiznich committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    cae96b1 View commit details
    Browse the repository at this point in the history
  13. Update src/doc/unstable-book/src/language-features/re-rebalance-coher…

    …ence.md
    
    Co-Authored-By: weiznich <[email protected]>
    varkor and weiznich committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    eee09d5 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    6912b2d View commit details
    Browse the repository at this point in the history
  15. Fix failing compile tests

    weiznich committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    44089c8 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    ad7d015 View commit details
    Browse the repository at this point in the history
  17. Unify tests

    Implement compile tests as variants of existing tests
    weiznich committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    8a5d45d View commit details
    Browse the repository at this point in the history
  18. Fix typo

    weiznich committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    da08a81 View commit details
    Browse the repository at this point in the history
  19. Add missing files

    weiznich committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    6caa4ce View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2018

  1. Rename and fix nolink-with-link-args test

    There are three problems with the nolink-with-link-args test:
    
    * The test fails when using MSVC. It's caused by the `linker-flavor=ld` flag which was added in rust-lang#46291.
    * In its comment, this test tests that "link_args are indeed passed when nolink is specified", but the `nolink` attribute has been removed [a long time ago](rust-lang#12826).
    * Pattern has a small typo.
    
    At first I was going to completely remove this test, but there is [a closed pull request for that](rust-lang#21090).
    
    So:
    
    * rename the file as suggested in the closed PR
    * adjust the comment
    * fix typo in the pattern
    * add `ignore-msvc`.
    Smibu committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    794b81e View commit details
    Browse the repository at this point in the history
  2. Fix backtraces on Windows

    Zoxc committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    f4826ab View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2019

  1. Configuration menu
    Copy the full SHA
    d2c91a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b903cb9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    88df3a2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1351328 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f36c655 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bb9f717 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    37a0df3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    17db209 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d96c4a9 View commit details
    Browse the repository at this point in the history
  10. Pacify tidy

    oli-obk committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    089c403 View commit details
    Browse the repository at this point in the history
  11. rebase fallout

    oli-obk committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    cb933ef View commit details
    Browse the repository at this point in the history
  12. Git is drunk

    oli-obk committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    3d924a6 View commit details
    Browse the repository at this point in the history
  13. what is going on?

    oli-obk committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    48aa819 View commit details
    Browse the repository at this point in the history
  14. Properly lift Allocations

    oli-obk committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    e42b21b View commit details
    Browse the repository at this point in the history
  15. Macrofy more Lift impls

    oli-obk committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    72bcf92 View commit details
    Browse the repository at this point in the history
  16. Remove unused function

    oli-obk committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    9654ae9 View commit details
    Browse the repository at this point in the history
  17. Check the correct arena

    oli-obk committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    03b8928 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2019

  1. Configuration menu
    Copy the full SHA
    185636e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0fd5003 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2a02d6d View commit details
    Browse the repository at this point in the history
  4. make panictry! private to libsyntax

    This commit completely removes usage of the `panictry!` macro from
    outside libsyntax. The macro causes parse errors to be fatal, so using
    it in libsyntax_ext caused parse failures *within* a syntax extension to
    be fatal, which is probably not intended.
    
    Furthermore, this commit adds spans to diagnostics emitted by empty
    extensions if they were missing, à la rust-lang#56491.
    euclio committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    0a6fb84 View commit details
    Browse the repository at this point in the history
  5. Update compiler_builtins 0.1.2 -> 0.1.3

    Jethro Beekman committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    0b6d217 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3852dc8 View commit details
    Browse the repository at this point in the history
  7. bootstrap: Link LLVM as a dylib with ThinLTO

    When building a distributed compiler on Linux where we use ThinLTO to
    create the LLVM shared object this commit switches the compiler to
    dynamically linking that LLVM artifact instead of statically linking to
    LLVM. The primary goal here is to reduce CI compile times, avoiding two+
    ThinLTO builds of all of LLVM. By linking dynamically to LLVM we'll
    reuse the one ThinLTO step done by LLVM's build itself.
    
    Lots of discussion about this change can be found [here] and down. A
    perf run will show whether this is worth it or not!
    
    [here]: rust-lang#53245 (comment)
    alexcrichton committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    ea7fef1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a175969 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    82a1bb3 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    fa4f014 View commit details
    Browse the repository at this point in the history
  11. Update the stdsimd submodule

    Add a new cmpxchg16b intrinsics for x86_64!
    alexcrichton committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    c0662a0 View commit details
    Browse the repository at this point in the history
  12. Don't package up libLLVM.so with libstd

    It's only meant for rustc, so we should only install it once!
    alexcrichton committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    71fed3a View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Fix 'be be' constructs

    I noticed a duplicated "be" somewhere in the code. A search for it
    manifested a couple more locations with the same problem. This change
    removes one of the "be"s.
    d-e-s-o committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    a944ecf View commit details
    Browse the repository at this point in the history
  2. More test deduplication

    weiznich committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    32118a9 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#55986 - cjgillot:issue-45510, r=nikomatsakis

    Allow to dispatch fn traits depending on number of parameters
    
    Hello,
    
    By following @eddyb's advise on issue rust-lang#45510, I managed to have the snippets of code in rust-lang#45510 and rust-lang#18952 passing without breaking older diagnostics.
    
    EDIT: the codegen tests breakage I experienced is due to the poor quality of my laptop.
    
    If any kind reviewer has any advice, you are very welcome.
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    677eef5 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#56145 - weiznich:re_rebalance_coherence, r=…

    …nikomatsakis
    
    Implement the Re-rebalance coherence RFC
    
    This is the first time I touch anything in the compiler so just tell me if I got something wrong.
    
    Big thanks to @sgrif for the pointers where to look for those things.
    cc rust-lang#55437
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    be8a496 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#56723 - oli-obk:lazy_const, r=nikomatsakis

    Don't emit `Unevaluated` from `const_eval`
    
    cc @eddyb @RalfJung
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    fee93ea View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#56897 - euclio:parse-fatal, r=estebank

    make `panictry!` private to libsyntax
    
    This commit completely removes usage of the `panictry!` macro from
    outside libsyntax. The macro causes parse errors to be fatal, so using
    it in libsyntax_ext caused parse failures *within* a syntax extension to
    be fatal, which is probably not intended.
    
    Furthermore, this commit adds spans to diagnostics emitted by empty
    extensions if they were missing, à la rust-lang#56491.
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    3baae65 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#57099 - davidtwco:issue-57098, r=nikomatsakis

    NLL: Add closure cannot be moved note.
    
    Fixes rust-lang#57098.
    
    This PR extends existing logic for checking whether a closure that
    is `FnOnce` and therefore moves variables that it captures from the
    environment has already been invoked when being invoked again.
    
    Now, this logic will also check whether the closure is being moved after
    previously being moved or invoked and add an appropriate note.
    
    r? @pnkfelix
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    c90bf0e View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#57101 - o01eg:fix-57014, r=alexcrichton

    Search codegen backends based on target libdir instead of sysroot
    
    Fixes rust-lang#57014
    
    Fixes cases with custom libdir when it consists of two or more parts.
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    4473e32 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#57145 - RalfJung:panic-if-uninhabited, r=al…

    …excrichton
    
    panic when calling MaybeUninhabited::into_inner on uninhabited type
    
    I do this by adding an internal-only intrinsic `panic_if_uninhabited`. I have no idea what I am doing here, just mindlessly copying code around, so please review carefully!
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    2701289 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#57219 - matthewjasper:mir-cleanup, r=nikoma…

    …tsakis
    
    Remove some unused code
    
    Closes rust-lang#57096
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    88818d6 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#57233 - Smibu:rename-and-fix-nolink-test, r…

    …=alexcrichton
    
    Rename and fix nolink-with-link-args test
    
    There are three problems with the nolink-with-link-args test:
    
    * The test fails when using MSVC. It's caused by the `linker-flavor=ld` flag which was added in rust-lang#46291.
    * In its comment, this test tests that "link_args are indeed passed when nolink is specified", but the `nolink` attribute has been removed [a long time ago](rust-lang#12826).
    * Pattern has a small typo.
    
    At first I was going to completely remove this test, but there is [a closed pull request for that](rust-lang#21090).
    
    So:
    
    * rename the file as suggested in the closed PR
    * adjust the comment
    * fix typo in the pattern
    * add `ignore-msvc`.
    
    r? @alexcrichton
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    ac58493 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#57238 - Zoxc:bt-fix, r=alexcrichton

    Fix backtraces for inlined functions on Windows
    
    Fixes an regression introduced in rust-lang#50526
    
    r? @alexcrichton
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    400d453 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#57249 - frewsxcv:frewsxcv-second-edition, r…

    …=KodrAus
    
    Fix broken links to second edition TRPL.
    
    Fixes rust-lang#57104.
    
    Remove `second-edition/` from TRPL hyperlinks.
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    028774c View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#57259 - king6cong:master, r=alexcrichton

    Update reference of rlibc crate to compiler-builtins crate
    
    None
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    e78b596 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#57267 - rust-lang:SimonSapin-patch-1, r=varkor

    src/jemalloc is gone, remove its mention from COPYRIGHT
    
    The `src/jemalloc` submodule was removed in 61e8944 / rust-lang#55238.
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    0496b18 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#57272 - petrochenkov:featrecov, r=estebank

    Make sure feature gate errors are recoverable (take 2)
    
    Continuation of rust-lang@15cefe4.
    Turns out I missed the most important part - the main feature gate checking pass.
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    f05bd30 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#57273 - alexcrichton:update-stdsimd, r=niko…

    …matsakis
    
    Update the stdsimd submodule
    
    Add a new cmpxchg16b intrinsics for x86_64 and some corrections for ARM/AArch64
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    cf56d3f View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#57275 - jethrogb:jb/update-compiler_builtin…

    …s, r=alexcrichton
    
    Update compiler_builtins 0.1.2 -> 0.1.3
    
    r? @alexcrichton
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    6e80fb1 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    e8472e4 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#57286 - alexcrichton:less-thin-2-2, r=nikom…

    …atsakis
    
    bootstrap: Link LLVM as a dylib with ThinLTO (take 2)
    
    When building a distributed compiler on Linux where we use ThinLTO to
    create the LLVM shared object this commit switches the compiler to
    dynamically linking that LLVM artifact instead of statically linking to
    LLVM. The primary goal here is to reduce CI compile times, avoiding two+
    ThinLTO builds of all of LLVM. By linking dynamically to LLVM we'll
    reuse the one ThinLTO step done by LLVM's build itself.
    
    Lots of discussion about this change can be found [here] and down. A
    perf run will show whether this is worth it or not!
    
    [here]: rust-lang#53245 (comment)
    
    ---
    
    This PR previously landed in rust-lang#56944, caused rust-lang#57111, and was reverted in rust-lang#57116. I've added one more commit here which should fix the breakage that we saw.
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    5508d36 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#57295 - d-e-s-o:topic/be-be, r=zackmdavis

    Fix 'be be' constructs
    
    I noticed a duplicated "be" somewhere in the code. A search for it
    manifested a couple more locations with the same problem. This change
    removes one of the "be"s.
    Mark-Simulacrum authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    6adc37e View commit details
    Browse the repository at this point in the history