Stabilize cfg_target_vendor #57465

jethrogb · 2019-01-09T08:34:38Z

This stabilizes the use of cfg(target_vendor = "...") and removes the corresponding cfg_target_vendor feature. Other unstable cfgs remain behind their existing feature gates.

This functionality was added back in 2015 in #28612 to complete the coverage of target tuples (<arch><sub>-<vendor>-<os>-<env>). RFC 131 governs the target specification, not including target_vendor seems to have just been an oversight. target_os, target_family, and target_arch are stable as of 1.0.0. target_env was also not mentioned in RFC 131, was added in #24777, never behind a feature_gate, and insta-stable at 1.1.0.

The functionality is tested in test/run-pass/cfg/cfg-target-vendor.rs.

Closes #29718

src/libsyntax/feature_gate.rs

Centril · 2019-01-09T08:44:40Z

r? @joshtriplett

Centril · 2019-01-09T08:46:31Z

@jethrogb Please file a documentation issue against the https://github.com/rust-lang-nursery/reference/ and link to this PR. Also, if you can help with adjusting the reference that would be good.

jethrogb · 2019-01-09T08:48:23Z

@Centril this is already documented.

Centril · 2019-01-09T08:59:24Z

@jethrogb OK; but the possible values are outdated and will need to be updated.

jethrogb · 2019-01-09T09:02:57Z

I've filed rust-lang/reference#502 but I think it's entirely orthogonal to this PR.

joshtriplett · 2019-01-09T14:18:21Z

@bors r+

bors · 2019-01-09T14:18:22Z

📌 Commit 224020c0853a091d0f588908f3bc0c9e3a772664 has been approved by joshtriplett

joshtriplett · 2019-01-09T14:35:27Z

On second thought, let's make sure people have a chance to confirm that this should be stabilized. I'll r+ if this goes through.

@bors r-
@rfcbot merge

rfcbot · 2019-01-09T14:35:28Z

Centril · 2019-01-14T08:56:14Z

@jethrogb Now that we're in FCP, per Josh's comment, #57465 (comment), I think we can ship this. Can you rebase first tho?

jethrogb · 2019-01-14T08:57:51Z

@Centril are you planning to merge this today for 1.33?

Centril · 2019-01-14T08:59:38Z

@jethrogb Yes, hopefully at least; we have 1 day to master=>beta promotion, so it should be sufficient time to merge this PR.

@bors p=1

jethrogb · 2019-01-14T09:03:49Z

Ok cool, wasn't sure if you wanted to wait for FCP or not. Rebased.

Centril · 2019-01-14T09:07:38Z

@bors r=joshtriplett,Centril

bors · 2019-01-14T09:07:39Z

📌 Commit 972bba7 has been approved by joshtriplett,Centril

…dor, r=joshtriplett,Centril Stabilize cfg_target_vendor This stabilizes the use of `cfg(target_vendor = "...")` and removes the corresponding `cfg_target_vendor` feature. Other unstable cfgs remain behind their existing feature gates. This functionality was added back in 2015 in rust-lang#28612 to complete the coverage of target tuples (`<arch><sub>-<vendor>-<os>-<env>`). [RFC 131](https://github.com/rust-lang/rfcs/blob/master/text/0131-target-specification.md) governs the target specification, not including `target_vendor` seems to have just been an oversight. `target_os`, `target_family`, and `target_arch` are stable as of 1.0.0. `target_env` was also not mentioned in RFC 131, was added in rust-lang#24777, never behind a feature_gate, and insta-stable at 1.1.0. The functionality is tested in [test/run-pass/cfg/cfg-target-vendor.rs](https://github.com/rust-lang/rust/blob/master/src/test/run-pass/cfg/cfg-target-vendor.rs). Closes rust-lang#29718

@ghost

Rollup of 6 pull requests Successful merges: - #57232 (Parallelize and optimize parts of HIR map creation) - #57418 (MetadataOnlyCodegenBackend: run the collector only once) - #57465 (Stabilize cfg_target_vendor) - #57477 (clarify resolve typo suggestion) - #57556 (privacy: Fix private-in-public check for existential types) - #57584 (Remove the `connect_timeout_unroutable` test.) Failed merges: r? @ghost

bors · 2019-01-14T15:45:40Z

⌛ Testing commit 972bba7 with merge d106808...

Pkgsrc changes: * Bump required rust version to build to 1.32.0. * Adapt patches to changed file locations. * Since we now patch some more vendor/ modules, doctor the corresponding .cargo-checksum.json files accordingly Upstream changes: Version 1.33.0 (2019-02-28) ========================== Language -------- - [You can now use the `cfg(target_vendor)` attribute.][57465] E.g. `#[cfg(target_vendor="apple")] fn main() { println!("Hello Apple!"); }` - [Integer patterns such as in a match expression can now be exhaustive.][56362] E.g. You can have match statement on a `u8` that covers `0..=255` and you would no longer be required to have a `_ => unreachable!()` case. - [You can now have multiple patterns in `if let` and `while let` expressions.][57532] You can do this with the same syntax as a `match` expression. E.g. ```rust enum Creature { Crab(String), Lobster(String), Person(String), } fn main() { let state = Creature::Crab("Ferris"); if let Creature::Crab(name) | Creature::Person(name) = state { println!("This creature's name is: {}", name); } } ``` - [You can now have irrefutable `if let` and `while let` patterns.][57535] Using this feature will by default produce a warning as this behaviour can be unintuitive. E.g. `if let _ = 5 {}` - [You can now use `let` bindings, assignments, expression statements, and irrefutable pattern destructuring in const functions.][57175] - [You can now call unsafe const functions.][57067] E.g. ```rust const unsafe fn foo() -> i32 { 5 } const fn bar() -> i32 { unsafe { foo() } } ``` - [You can now specify multiple attributes in a `cfg_attr` attribute.][57332] E.g. `#[cfg_attr(all(), must_use, optimize)]` - [You can now specify a specific alignment with the `#[repr(packed)]` attribute.][57049] E.g. `#[repr(packed(2))] struct Foo(i16, i32);` is a struct with an alignment of 2 bytes and a size of 6 bytes. - [You can now import an item from a module as an `_`.][56303] This allows you to import a trait's impls, and not have the name in the namespace. E.g. ```rust use std::io::Read as _; // Allowed as there is only one `Read` in the module. pub trait Read {} ``` - [You may now use `Rc`, `Arc`, and `Pin` as method receivers][56805]. Compiler -------- - [You can now set a linker flavor for `rustc` with the `-Clinker-flavor` command line argument.][56351] - [The mininum required LLVM version has been bumped to 6.0.][56642] - [Added support for the PowerPC64 architecture on FreeBSD.][57615] - [The `x86_64-fortanix-unknown-sgx` target support has been upgraded to tier 2 support.][57130] Visit the [platform support][platform-support] page for information on Rust's platform support. - [Added support for the `thumbv7neon-linux-androideabi` and `thumbv7neon-unknown-linux-gnueabihf` targets.][56947] - [Added support for the `x86_64-unknown-uefi` target.][56769] Libraries --------- - [The methods `overflowing_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57566] - [The methods `rotate_left`, `rotate_right`, and `wrapping_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57105] - [The methods `is_positive` and `is_negative` are now `const` functions for all signed numeric types.][57105] - [The `get` method for all `NonZero` types is now `const`.][57167] - [The methods `count_ones`, `count_zeros`, `leading_zeros`, `trailing_zeros`, `swap_bytes`, `from_be`, `from_le`, `to_be`, `to_le` are now `const` for all numeric types.][57234] - [`Ipv4Addr::new` is now a `const` function][57234] Stabilized APIs --------------- - [`unix::FileExt::read_exact_at`] - [`unix::FileExt::write_all_at`] - [`Option::transpose`] - [`Result::transpose`] - [`convert::identity`] - [`pin::Pin`] - [`marker::Unpin`] - [`marker::PhantomPinned`] - [`Vec::resize_with`] - [`VecDeque::resize_with`] - [`Duration::as_millis`] - [`Duration::as_micros`] - [`Duration::as_nanos`] Cargo ----- - [Cargo should now rebuild a crate if a file was modified during the initial build.][cargo/6484] Compatibility Notes ------------------- - The methods `str::{trim_left, trim_right, trim_left_matches, trim_right_matches}` are now deprecated in the standard library, and their usage will now produce a warning. Please use the `str::{trim_start, trim_end, trim_start_matches, trim_end_matches}` methods instead. - The `Error::cause` method has been deprecated in favor of `Error::source` which supports downcasting. [55982]: rust-lang/rust#55982 [56303]: rust-lang/rust#56303 [56351]: rust-lang/rust#56351 [56362]: rust-lang/rust#56362 [56642]: rust-lang/rust#56642 [56769]: rust-lang/rust#56769 [56805]: rust-lang/rust#56805 [56947]: rust-lang/rust#56947 [57049]: rust-lang/rust#57049 [57067]: rust-lang/rust#57067 [57105]: rust-lang/rust#57105 [57130]: rust-lang/rust#57130 [57167]: rust-lang/rust#57167 [57175]: rust-lang/rust#57175 [57234]: rust-lang/rust#57234 [57332]: rust-lang/rust#57332 [57465]: rust-lang/rust#57465 [57532]: rust-lang/rust#57532 [57535]: rust-lang/rust#57535 [57566]: rust-lang/rust#57566 [57615]: rust-lang/rust#57615 [cargo/6484]: rust-lang/cargo#6484 [`unix::FileExt::read_exact_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.read_exact_at [`unix::FileExt::write_all_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.write_all_at [`Option::transpose`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.transpose [`Result::transpose`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.transpose [`convert::identity`]: https://doc.rust-lang.org/std/convert/fn.identity.html [`pin::Pin`]: https://doc.rust-lang.org/std/pin/struct.Pin.html [`marker::Unpin`]: https://doc.rust-lang.org/stable/std/marker/trait.Unpin.html [`marker::PhantomPinned`]: https://doc.rust-lang.org/nightly/std/marker/struct.PhantomPinned.html [`Vec::resize_with`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.resize_with [`VecDeque::resize_with`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.resize_with [`Duration::as_millis`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_millis [`Duration::as_micros`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_micros [`Duration::as_nanos`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_nanos [platform-support]: https://forge.rust-lang.org/platform-support.html

This is because the updated rand_core crate to 0.6 uses getrandom at version 0.2 which uses the cfg_target_vendor feature which was stabilized at 1.33: rust-lang/rust#57465

rust-highfive assigned GuillaumeGomez Jan 9, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 9, 2019

jethrogb mentioned this pull request Jan 9, 2019

Tracking issue for cfg_target_vendor #29718

Closed

Centril added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Jan 9, 2019

Centril suggested changes Jan 9, 2019

View reviewed changes

src/libsyntax/feature_gate.rs Show resolved Hide resolved

rust-highfive assigned joshtriplett and unassigned GuillaumeGomez Jan 9, 2019

rust-lang deleted a comment from rust-highfive Jan 9, 2019

Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 9, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 9, 2019

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jan 9, 2019

joshtriplett removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 9, 2019

Centril added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). I-nominated and removed I-nominated labels Jan 9, 2019

Centril approved these changes Jan 10, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jan 14, 2019

Jethro Beekman added 2 commits January 14, 2019 14:32

Add additional human-readable cfg strings to rustdoc

6080318

Stabilize cfg_target_vendor, rust-lang#29718

972bba7

jethrogb force-pushed the jb/stablize-cfg-target-vendor branch from 224020c to 972bba7 Compare January 14, 2019 09:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Jan 14, 2019

Centril mentioned this pull request Jan 14, 2019

Rollup of 6 pull requests #57592

Merged

bors merged commit 972bba7 into rust-lang:master Jan 14, 2019

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jan 24, 2019

tomoyuki-nakabayashi mentioned this pull request Mar 2, 2019

fix compile error in the latest nightly 1.33.0. souvik1997/kernel-roulette#1

Merged

Centril added this to the 1.33 milestone Apr 26, 2019

hanmertens mentioned this pull request Feb 17, 2021

Add support for non-UTF-8 strings murarth/gumdrop#46

Open

tgross35 mentioned this pull request Aug 7, 2024

macOs various updates. rust-lang/libc#3578

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize cfg_target_vendor #57465

Stabilize cfg_target_vendor #57465

jethrogb commented Jan 9, 2019 •

edited

Loading

Centril commented Jan 9, 2019

Centril commented Jan 9, 2019

jethrogb commented Jan 9, 2019 •

edited

Loading

Centril commented Jan 9, 2019

jethrogb commented Jan 9, 2019

joshtriplett commented Jan 9, 2019

bors commented Jan 9, 2019

joshtriplett commented Jan 9, 2019

rfcbot commented Jan 9, 2019 •

edited by eddyb

Loading

This comment has been minimized.

Centril commented Jan 14, 2019

jethrogb commented Jan 14, 2019

Centril commented Jan 14, 2019

jethrogb commented Jan 14, 2019

Centril commented Jan 14, 2019

bors commented Jan 14, 2019

bors commented Jan 14, 2019

Stabilize cfg_target_vendor #57465

Stabilize cfg_target_vendor #57465

Conversation

jethrogb commented Jan 9, 2019 • edited Loading

Centril commented Jan 9, 2019

Centril commented Jan 9, 2019

jethrogb commented Jan 9, 2019 • edited Loading

Centril commented Jan 9, 2019

jethrogb commented Jan 9, 2019

joshtriplett commented Jan 9, 2019

bors commented Jan 9, 2019

joshtriplett commented Jan 9, 2019

rfcbot commented Jan 9, 2019 • edited by eddyb Loading

This comment has been minimized.

Centril commented Jan 14, 2019

jethrogb commented Jan 14, 2019

Centril commented Jan 14, 2019

jethrogb commented Jan 14, 2019

Centril commented Jan 14, 2019

bors commented Jan 14, 2019

bors commented Jan 14, 2019

jethrogb commented Jan 9, 2019 •

edited

Loading

jethrogb commented Jan 9, 2019 •

edited

Loading

rfcbot commented Jan 9, 2019 •

edited by eddyb

Loading