Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the IP address in the connect_timeout_unroutable test. #57506

Closed
wants to merge 1 commit into from
Closed

Change the IP address in the connect_timeout_unroutable test. #57506

wants to merge 1 commit into from

Conversation

nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Jan 11, 2019 •
edited by varkor
Loading

Because the current address is reachable on some machines, which causes
the test to fail.

Fixes #44698, fixes #50065.

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 11, 2019
@nnethercote
Copy link
Contributor Author

I can't guarantee this will work universally, for reasons explained in the comment. But it fixes the test failure for my Ubuntu 18.04 box.

@nnethercote
Copy link
Contributor Author

#44698 has some extra info. @RalfJung said changing to 192.0.2.2 didn't fix the problem, which is disappointing. @bobtwinkles suggested "disabling it on non-CI builds by default" -- what would that look like?

@nnethercote
Change the IP address in the connect_timeout_unroutable test.
ca26d44 
Because the current address is reachable on some machines, which causes
the test to fail.

Fixes rust-lang#44698, rust-lang#50065.
@dtolnay
Copy link
Member

dtolnay commented Jan 11, 2019

r? @sfackler

@rust-highfive rust-highfive assigned sfackler and unassigned dtolnay Jan 11, 2019
@nagisa
Copy link
Member

nagisa commented Jan 11, 2019

This test should just go. There are so many ways this could do something else for any IP that it makes no sense to test for it without mocking out the system call.

@nnethercote
Copy link
Contributor Author

This test should just go.

I filed #57584, which removes the test, as an alternative. I'll let @sfackler decide which approach is better.

@nnethercote
Copy link
Contributor Author

@sfackler approved #57584, so I'll close this.

@nnethercote nnethercote deleted the fix-connect_timeout_unroutable branch January 14, 2019 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
5 participants
@nnethercote @rust-highfive @dtolnay @nagisa @sfackler