Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid background color #57859

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Conversation

GuillaumeGomez
Copy link
Member

As discussed in #57814.

r? @QuietMisdreavus

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 23, 2019
@QuietMisdreavus
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 28, 2019

📌 Commit 0cf9704 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 28, 2019
…ietMisdreavus

Fix invalid background color

As discussed in rust-lang#57814.

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this pull request Jan 28, 2019
…ietMisdreavus

Fix invalid background color

As discussed in rust-lang#57814.

r? @QuietMisdreavus
bors added a commit that referenced this pull request Jan 29, 2019
Rollup of 7 pull requests

Successful merges:

 - #57045 (Kill remaining uses of mem::uninitialized in libcore, liballoc)
 - #57674 (Avoid erase_regions_ty queries if there are no regions to erase)
 - #57833 (Print a slightly clearer message when failing to launch a thread)
 - #57859 (Fix invalid background color)
 - #57904 (add typo suggestion to unknown attribute error)
 - #57915 (Pretty print `$crate` as `crate` or `crate_name` in more cases)
 - #57950 (Extend E0106, E0261)

Failed merges:

r? @ghost
@bors bors merged commit 0cf9704 into rust-lang:master Jan 29, 2019
@GuillaumeGomez GuillaumeGomez deleted the fix-background branch January 29, 2019 09:14
@GuillaumeGomez GuillaumeGomez added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Feb 18, 2019
@GuillaumeGomez
Copy link
Member Author

cc @QuietMisdreavus

@QuietMisdreavus QuietMisdreavus added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed stable-nominated Nominated for backporting to the compiler in the stable channel. labels Feb 18, 2019
@QuietMisdreavus
Copy link
Member

Accepting beta nomination, but removing the stable nomination because the issue is not on stable.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 22, 2019
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 22, 2019
bors added a commit that referenced this pull request Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants