Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #58428

Closed
wants to merge 36 commits into from
Closed

Rollup of 10 pull requests #58428

wants to merge 36 commits into from

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Feb 13, 2019

Successful merges:

Failed merges:

r? @ghost

fitzgen and others added 30 commits February 7, 2019 12:33
Instead of inlining the same logic into every number formatting implementation,
pull it out into a function that each of the number formatting impls call into.
The generic `F` in `with_padding` was causing a bunch of stuff to get inlined
that otherwise needn't be, blowing up code size.
This makes the capitalisation consistent and provides more context (especially for missing top-level attributes).
Removes some unsafe *and* saves almost half a kilobyte of code size.
This commit modifies name resolution error reporting so that if a name
is in scope and has been imported then we do not suggest importing it.

This can occur when we add a label about constructors not being visible
due to private fields. In these cases, we know that the struct/variant
has been imported and we should silence any suggestions to import the
struct/variant.
This clarifies why FP-units are disabled on UEFI targets, as well as
why we must opt into the NXCOMPAT feature.

I did find some time to investigate why GRUB and friends disable FP on
UEFI. The specification explicitly allows using MMX/SSE/AVX, but as it
turns out it does not mandate enabling the instruction sets explicitly.
Hence, any use of these instructions will trigger CPU exceptions,
unless an application explicitly enables them (which is not an option,
as these are global flags that better be controlled by the
kernel/firmware).

Furthermore, UEFI systems are allowed to mark any non-code page as
non-executable. Hence, we must make sure to never place code on the
stack or heap. So we better pass /NXCOMPAT to the linker for it to
complain if it ever places code in non-code pages.

Lastly, this fixes some typos in related comments.
…-obk

libpanic_unwind => 2018

Transitions `libpanic_unwind` to Rust 2018; cc rust-lang#58099

r? @oli-obk
…r=GuillaumeGomez

Ignore future deprecations in #[deprecated]

The future deprecation warnings should only apply to `#[rustc_deprecated]` as they take into account rustc's version. Fixes rust-lang#57952.

I've also slightly modified rustdoc's display of future deprecation notices to make it more consistent, so I'm assigning a rustdoc team member for review to make sure this is okay.

r? @GuillaumeGomez
…k-Simulacrum

Cut down on number formating code size

r? @alexcrichton
…evel, r=davidtwco

Improve the error messages for missing stability attributes

This makes the capitalisation consistent and provides more context (especially for missing top-level attributes).
…leywiser

Fix ICE and invalid filenames in MIR printing code

* Don't panic when printing MIR for associated constants
* Don't use `<` and `>` in filenames, since they aren't allowed on Windows.

r? @eddyb

cc @RalfJung
Only suggest imports if not imported.

Fixes rust-lang#42944 and fixes rust-lang#53430.

This commit modifies name resolution error reporting so that if a name
is in scope and has been imported then we do not suggest importing it.

This can occur when we add a label about constructors not being visible
due to private fields. In these cases, we know that the struct/variant
has been imported and we should silence any suggestions to import the
struct/variant.

r? @estebank
Fix rustc_driver swallowing errors when compilation is stopped

r? @oli-obk
target/uefi: clarify documentation

This clarifies why FP-units are disabled on UEFI targets, as well as
why we must opt into the NXCOMPAT feature.

I did find some time to investigate why GRUB and friends disable FP on
UEFI. The specification explicitly allows using MMX/SSE/AVX, but as it
turns out it does not mandate enabling the instruction sets explicitly.
Hence, any use of these instructions will trigger CPU exceptions,
unless an application explicitly enables them (which is not an option,
as these are global flags that better be controlled by the
kernel/firmware).

Furthermore, UEFI systems are allowed to mark any non-code page as
non-executable. Hence, we must make sure to never place code on the
stack or heap. So we better pass /NXCOMPAT to the linker for it to
complain if it ever places code in non-code pages.

Lastly, this fixes some typos in related comments.

r? @alexcrichton
@Centril
Copy link
Contributor Author

Centril commented Feb 13, 2019

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Feb 13, 2019

📌 Commit f4dfad8 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 13, 2019
@bors
Copy link
Contributor

bors commented Feb 13, 2019

⌛ Testing commit f4dfad8 with merge b265edfa4bac39cdc0972783e25679274d4d8f02...

@bors
Copy link
Contributor

bors commented Feb 13, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

The job dist-various-2 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:57:35]    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[00:57:35] error: unused extern crate
[00:57:35]   --> src/libpanic_unwind/lib.rs:38:1
[00:57:35]    |
[00:57:35] 37 | / #[cfg(not(any(target_env = "msvc", all(windows, target_arch = "x86_64", target_env = "gnu"))))]
[00:57:35] 38 | | extern crate unwind;
[00:57:35]    | | ^^^^^^^^^^^^^^^^^^^-
[00:57:35]    | |____________________|
[00:57:35]    |
[00:57:35] note: lint level defined here
[00:57:35]   --> src/libpanic_unwind/lib.rs:20:9
[00:57:35]    |
[00:57:35]    |
[00:57:35] 20 | #![deny(rust_2018_idioms)]
[00:57:35]    |         ^^^^^^^^^^^^^^^^
[00:57:35]    = note: #[deny(unused_extern_crates)] implied by #[deny(rust_2018_idioms)]
[00:57:35] error: aborting due to previous error
[00:57:35] 
[00:57:35] [RUSTC-TIMING] panic_unwind test:false 0.121
[00:57:35] error: Could not compile `panic_unwind`.
---
travis_time:end:15a17c60:start=1550077320708551824,finish=1550077320721321697,duration=12769873
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0a2caf57
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:14b99a1b
travis_time:start:14b99a1b
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0f33de15
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 13, 2019
@Centril Centril closed this Feb 13, 2019
@Centril Centril deleted the rollup branch February 13, 2019 17:04
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler panics during incremental recompilation, while using an associated constant as array size