Auto #58682
Closed
Auto #58682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately this'll dupe parking_lot until the data_structures crate is published and be updated in rls in conjunction with crossbeam-channel
Update parking_lot to 0.7 Unfortunately this'll dupe parking_lot until the data_structures crate is published and be updated in rls in conjunction with crossbeam-channel
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Opened by accident I presume? Closing. |
|
Merge so I can review the code
…On Sat, Feb 23, 2019, 10:58 PM Rust highfive robot ***@***.*** wrote:
Thanks for the pull request, and welcome! The Rust team is excited to
review your changes, and you should hear from @nikomatsakis
<https://github.com/nikomatsakis> (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra
commits. This ensures that the reviewer can see what has changed since they
last reviewed the code. Due to the way GitHub handles out-of-date commits,
this should also make it reasonably obvious what issues have or haven't
been addressed. Large or tricky changes may require several passes of
review and changes.
Please see the contribution instructions
<https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md> for more
information.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#58682 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARn-PIS165ActbbtnYBEf8O-m64aD9djks5vQZ2BgaJpZM4bOIU9>
.
|
|
The branch just contains #57051, so not sure why you need another PR? |
|
CI is failing
…On Sat, Feb 23, 2019, 10:58 PM Rust highfive robot ***@***.*** wrote:
Thanks for the pull request, and welcome! The Rust team is excited to
review your changes, and you should hear from @nikomatsakis
<https://github.com/nikomatsakis> (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra
commits. This ensures that the reviewer can see what has changed since they
last reviewed the code. Due to the way GitHub handles out-of-date commits,
this should also make it reasonably obvious what issues have or haven't
been addressed. Large or tricky changes may require several passes of
review and changes.
Please see the contribution instructions
<https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md> for more
information.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#58682 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARn-PIS165ActbbtnYBEf8O-m64aD9djks5vQZ2BgaJpZM4bOIU9>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto