Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xfail'd ARC test #5881

Closed
wants to merge 1 commit into from
Closed

Fix xfail'd ARC test #5881

wants to merge 1 commit into from

Conversation

danluu
Copy link
Contributor

@danluu danluu commented Apr 14, 2013

Update an old test to pass. I'm not 100% sure what the intent of the test was, but it's hard to see how I could have corrupted the intent of the test from the tiny changes I made.

bors added a commit that referenced this pull request Apr 15, 2013
Update an old test to pass. I'm not 100% sure what the intent of the test was, but it's hard to see how I could have corrupted the intent of the test from the tiny changes I made.
@bors bors closed this Apr 15, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 28, 2020
…=ebroto,flip1995

Lint `push_str` with a single-character string literal

Fixes rust-lang#5875
changelog:  `* [single_char_push_str]`
calebcartwright pushed a commit to calebcartwright/rust that referenced this pull request Oct 23, 2023
* Inline format arguments for easier reading

Code becomes shorter and often easier to read when format args are inlined.  Note that I skipped the mixed cases to make it more straightforward (could be done separatelly).

Also, there are two FIXME comments - for some reasons inlining makes format string exceed 100 char line width and crash.

```
cargo clippy --workspace --allow-dirty --fix --benches --tests --bins -- -A clippy::all -W clippy::uninlined_format_args
```

* address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants