adjust MaybeUninit API to discussions #59284

RalfJung · 2019-03-18T21:47:37Z

uninitialized -> uninit
into_initialized -> assume_init
read_initialized -> read
set -> write

rust-highfive · 2019-03-18T21:47:48Z

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

jethrogb · 2019-03-18T21:53:31Z

Missed some in

src/libstd/sys/sgx/rwlock.rs
src/libstd/sys/sgx/ext/arch.rs

RalfJung · 2019-03-19T08:50:16Z

Thanks for pointing that out!

The one in rwlock.rs actually already did not compile, it still used into_inner...

sfackler · 2019-03-20T00:24:48Z

src/libcore/mem.rs

+    /// Deprecated before stabilization.
+    #[unstable(feature = "maybe_uninit", issue = "53491")]
+    #[inline(always)]
+    // FIXME: still used by stdsimd


We should be able to future-deprecate it even though stdsimd uses it, right?

We have warn(deprecated_in_future) and also on CI compile with -D warnings. So I'm afraid I don't think we can.

sfackler · 2019-03-25T04:21:25Z

@bors r+

bors · 2019-03-25T04:21:26Z

📌 Commit 9374efa has been approved by sfackler

adjust MaybeUninit API to discussions uninitialized -> uninit into_initialized -> assume_init read_initialized -> read set -> write

Centril · 2019-03-26T05:05:03Z

@bors r- due to merge conflict.

bors · 2019-03-26T05:08:16Z

☔ The latest upstream changes (presumably #59136) made this pull request unmergeable. Please resolve the merge conflicts.

uninitialized -> uninit into_initialized -> assume_init read_initialized -> read set -> write

RalfJung · 2019-03-26T08:58:14Z

Rebased.

@bors r=sfackler

bors · 2019-03-26T08:58:15Z

📌 Commit 853ae8d has been approved by sfackler

adjust MaybeUninit API to discussions uninitialized -> uninit into_initialized -> assume_init read_initialized -> read set -> write

@ghost

Rollup of 18 pull requests Successful merges: - #57293 (Make some lints incremental) - #57565 (syntax: Remove warning for unnecessary path disambiguators) - #58253 (librustc_driver => 2018) - #58837 (librustc_interface => 2018) - #59268 (Add suggestion to use `&*var` when `&str: From<String>` is expected) - #59283 (Make ASCII case conversions more than 4× faster) - #59284 (adjust MaybeUninit API to discussions) - #59372 (add rustfix-able suggestions to trim_{left,right} deprecations) - #59390 (Make `ptr::eq` documentation mention fat-pointer behavior) - #59393 (Refactor tuple comparison tests) - #59420 ([CI] record docker image info for reuse) - #59421 (Reject integer suffix when tuple indexing) - #59430 (Renames `EvalContext` to `InterpretCx`) - #59439 (Generalize diagnostic for `x = y` where `bool` is the expected type) - #59449 (fix: Make incremental artifact deletion more robust) - #59451 (Add `Default` to `std::alloc::System`) - #59459 (Add some tests) - #59460 (Include id in Thread's Debug implementation) Failed merges: r? @ghost

jethrogb · 2019-03-29T00:46:21Z

Testing std stage1 (x86_64-unknown-linux-gnu -> x86_64-fortanix-unknown-sgx)
   Compiling std v0.0.0 (/home/jenkins/workspace/rust-sgx-ci/rust/src/libstd)
error: use of deprecated item 'core::mem::MaybeUninit::<T>::set': use `write` instead
   --> src/libstd/sys/sgx/rwlock.rs:271:18
    |
271 |             init.set(RWLock::new());
    |                  ^^^
    |
= note: `-D deprecated` implied by `-D warnings`

…=Centril Fix missed fn rename in rust-lang#59284 See rust-lang#59284 (comment)

@ghost

Rollup of 11 pull requests Successful merges: - #58019 (Combine all builtin late lints and make lint checking parallel) - #59358 (Use `track_errors` instead of hand rolling) - #59394 (warn -> deny duplicate match bindings) - #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes) - #59423 (Visit path in `walk_mac`) - #59468 (musl: build toolchain libs with -fPIC) - #59476 (Use `SmallVec` in `TokenStreamBuilder`.) - #59496 (Remove unnecessary with_globals calls) - #59498 (Use 'write_all' instead of 'write' in example code) - #59503 (Stablize {f32,f64}::copysign().) - #59511 (Fix missed fn rename in #59284) Failed merges: r? @ghost

@ghost

Rollup of 11 pull requests Successful merges: - #58019 (Combine all builtin late lints and make lint checking parallel) - #59358 (Use `track_errors` instead of hand rolling) - #59394 (warn -> deny duplicate match bindings) - #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes) - #59423 (Visit path in `walk_mac`) - #59468 (musl: build toolchain libs with -fPIC) - #59476 (Use `SmallVec` in `TokenStreamBuilder`.) - #59496 (Remove unnecessary with_globals calls) - #59498 (Use 'write_all' instead of 'write' in example code) - #59503 (Stablize {f32,f64}::copysign().) - #59511 (Fix missed fn rename in #59284) Failed merges: r? @ghost

RalfJung · 2019-03-29T08:57:42Z

Sorry, seems like I missed one use. :/

after rust-lang/rust#59284

rust-highfive assigned sfackler Mar 18, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2019

This was referenced Mar 18, 2019

Tracking issue for RFC 1892, "Deprecate uninitialized in favor of a new MaybeUninit type" #53491

Closed

adjust to MaybeUninit renames rust-lang/stdarch#707

Merged

sfackler reviewed Mar 20, 2019

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2019

Centril added a commit to Centril/rust that referenced this pull request Mar 26, 2019

Rollup merge of rust-lang#59284 - RalfJung:maybe-uninit, r=sfackler

e061309

adjust MaybeUninit API to discussions uninitialized -> uninit into_initialized -> assume_init read_initialized -> read set -> write

Centril mentioned this pull request Mar 26, 2019

Rollup of 12 pull requests #59428

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2019

RalfJung added 2 commits March 26, 2019 09:21

adjust MaybeUninit API to discussions

0e0383a

uninitialized -> uninit into_initialized -> assume_init read_initialized -> read set -> write

fix some uses I missed

853ae8d

RalfJung force-pushed the maybe-uninit branch from 9374efa to 853ae8d Compare March 26, 2019 08:23

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2019

Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019

Rollup merge of rust-lang#59284 - RalfJung:maybe-uninit, r=sfackler

27929b0

adjust MaybeUninit API to discussions uninitialized -> uninit into_initialized -> assume_init read_initialized -> read set -> write

Centril mentioned this pull request Mar 27, 2019

Rollup of 13 pull requests #59457

Closed

Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019

Rollup merge of rust-lang#59284 - RalfJung:maybe-uninit, r=sfackler

0052b80

adjust MaybeUninit API to discussions uninitialized -> uninit into_initialized -> assume_init read_initialized -> read set -> write

Centril mentioned this pull request Mar 27, 2019

Rollup of 14 pull requests #59461

Closed

Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019

Rollup merge of rust-lang#59284 - RalfJung:maybe-uninit, r=sfackler

5562519

adjust MaybeUninit API to discussions uninitialized -> uninit into_initialized -> assume_init read_initialized -> read set -> write

Centril mentioned this pull request Mar 27, 2019

Rollup of 17 pull requests #59466

Closed

cuviper added a commit to cuviper/rust that referenced this pull request Mar 28, 2019

Rollup merge of rust-lang#59284 - RalfJung:maybe-uninit, r=sfackler

ad5bbf0

adjust MaybeUninit API to discussions uninitialized -> uninit into_initialized -> assume_init read_initialized -> read set -> write

cuviper mentioned this pull request Mar 28, 2019

Rollup of 18 pull requests #59471

Merged

bors merged commit 853ae8d into rust-lang:master Mar 28, 2019

jethrogb mentioned this pull request Mar 29, 2019

Rollup of 10 pull requests #59487

Merged

jethrogb pushed a commit to jethrogb/rust that referenced this pull request Mar 29, 2019

Fix missed fn rename in rust-lang#59284

93fb4d8

jethrogb mentioned this pull request Mar 29, 2019

Fix missed fn rename in #59284 #59511

Merged

Centril added a commit to Centril/rust that referenced this pull request Mar 29, 2019

Rollup merge of rust-lang#59511 - jethrogb:jb/maybeinit-deprecated, r…

456fa39

…=Centril Fix missed fn rename in rust-lang#59284 See rust-lang#59284 (comment)

Centril mentioned this pull request Mar 29, 2019

Rollup of 11 pull requests #59513

Merged

RalfJung deleted the maybe-uninit branch March 29, 2019 08:57

chrysn added a commit to RIOT-OS/rust-riot-sys that referenced this pull request May 31, 2022

Adjust to MaybeUninit API

5b94781

after rust-lang/rust#59284

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adjust MaybeUninit API to discussions #59284

adjust MaybeUninit API to discussions #59284

RalfJung commented Mar 18, 2019

rust-highfive commented Mar 18, 2019

jethrogb commented Mar 18, 2019

RalfJung commented Mar 19, 2019

sfackler Mar 20, 2019

RalfJung Mar 20, 2019 •

edited

Loading

sfackler commented Mar 25, 2019

bors commented Mar 25, 2019

Centril commented Mar 26, 2019

bors commented Mar 26, 2019

RalfJung commented Mar 26, 2019

bors commented Mar 26, 2019

jethrogb commented Mar 29, 2019

RalfJung commented Mar 29, 2019

adjust MaybeUninit API to discussions #59284

adjust MaybeUninit API to discussions #59284

Conversation

RalfJung commented Mar 18, 2019

rust-highfive commented Mar 18, 2019

jethrogb commented Mar 18, 2019

RalfJung commented Mar 19, 2019

sfackler Mar 20, 2019

Choose a reason for hiding this comment

RalfJung Mar 20, 2019 • edited Loading

Choose a reason for hiding this comment

sfackler commented Mar 25, 2019

bors commented Mar 25, 2019

Centril commented Mar 26, 2019

bors commented Mar 26, 2019

RalfJung commented Mar 26, 2019

bors commented Mar 26, 2019

jethrogb commented Mar 29, 2019

RalfJung commented Mar 29, 2019

RalfJung Mar 20, 2019 •

edited

Loading