Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #59730

Closed
wants to merge 20 commits into from
Closed

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Apr 5, 2019

Successful merges:

Failed merges:

r? @ghost

cramertj and others added 20 commits March 12, 2019 16:50
…mertj

Unsized rvalues: implement boxed closure impls. (2nd try)

This is a rebase of S-blocked-closed PR rust-lang#55431 to current master. LLVM has moved forward since then, so maybe we can check whether the new LLVM 8.0 version unblocked this work.
…crichton

SGX target: Use linker option to avoid code CGU assignment kludge

cc @VardhanThigle @faern
…=alexcrichton

Remove invalid assertion back::link::from add_upstream_rust_crates().

This removes a misplaced assertion. The function containing the assertion is actually only ever called for upstream crates that are not considered for LTO, so we don't care whether upstream code has been merged in by LTO or not.

Fixes rust-lang#59137

r? @alexcrichton
@Centril
Copy link
Contributor Author

Centril commented Apr 5, 2019

@bors r+ p=4

@bors
Copy link
Contributor

bors commented Apr 5, 2019

📌 Commit 5a93250 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 5, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:00fd75e6:start=1554484533056697214,finish=1554484619062687760,duration=86005990546
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[00:04:31]    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[00:04:33] error: hidden lifetime parameters in types are deprecated
[00:04:33]    --> src/libstd/panic.rs:326:44
[00:04:33]     |
[00:04:33] 326 |     fn poll(self: Pin<&mut Self>, cx: &mut Context) -> Poll<Self::Output> {
[00:04:33] 
[00:04:35] error: aborting due to previous error
[00:04:35] 
[00:04:35] error: Could not compile `std`.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril Centril closed this Apr 5, 2019
@Centril Centril deleted the rollup-f1bm6sd branch April 5, 2019 17:25
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants