bump stdsimd; make intra_doc_link_resolution_failure an error again; make lints more consistent #59955
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
| @@ -60,8 +60,8 @@ | |||
|
|
|||
| #![warn(deprecated_in_future)] | |||
| #![warn(missing_docs)] | |||
There was a problem hiding this comment.
Btw @alexcrichton is there any reason liballoc does not have warn(missing_docs)? Should I add it there as well to make things more consistent?
The other inconsistency I noticed is that libcore does not have deny(rust_2018_idioms). But that seems people just didn't get there yet.
There was a problem hiding this comment.
It is being worked on, #58702.
There was a problem hiding this comment.
@RalfJung when those annotations were added it wasn't needed, now that it's a stable crate we probably need it
There was a problem hiding this comment.
Okay, I added the attribute. That uncovered a few missing docs, and indeed for items that got reexported in std! So I also added docs.
RalfJung
changed the title
LGTM. It appears that every time you update stdsimd, some new feature lands, you are our luck hero ! This updates lands all MIPS MSA SIMD intrinsics on nightly, which were added by @rbirdic in this massive PR: rust-lang/stdarch#709 |
|
@bors: r+ |
|
📌 Commit 8ef7ca1 has been approved by |
bors
added
S-waiting-on-bors
|
@bors: r+ |
|
📌 Commit 50c615b has been approved by |
bump stdsimd; make intra_doc_link_resolution_failure an error again; make lints more consistent I made `intra_doc_link_resolution_failure` warn so that it would properly respect `deny-warnings = false` in `config.toml`. `#[warn]` still become errors with `-D warnings` so I thought this was fine. Turns out however that we don't pass `-D warnings` when running rustdoc, so for additional rustdoc-lints we need to set them to `deny`. Also sue the opportunity to make the lint flags more consistent between libcore, liballoc, libstd. Cc @gnzlbg for the *big* stdsimd update.
Rollup of 6 pull requests Successful merges: - #59648 (Add must_use annotations to Result::is_ok and is_err) - #59748 (Add summary and reference to Rust trademark guide) - #59779 (Uplift `get_def_path` from Clippy) - #59955 (bump stdsimd; make intra_doc_link_resolution_failure an error again; make lints more consistent) - #59978 (rustdoc: Remove default keyword from re-exported trait methods) - #59989 (Fix links to Atomic* in RELEASES.md) Failed merges: r? @ghost
I made
intra_doc_link_resolution_failurewarn so that it would properly respectdeny-warnings = falseinconfig.toml.#[warn]still become errors with-D warningsso I thought this was fine.Turns out however that we don't pass
-D warningswhen running rustdoc, so for additional rustdoc-lints we need to set them todeny.Also sue the opportunity to make the lint flags more consistent between libcore, liballoc, libstd.
Cc @gnzlbg for the big stdsimd update.