Stabilize ADX, TBM, and SSE4a target features #60109

gnzlbg · 2019-04-19T09:30:46Z

This PR stabilizes the ADX, TBM, and SSE4a target features.

We stabilized the ADX core::arch intrinsics in Rust 1.33, and the TBM and SSE4a intrinsics have been accidentally stabilized since Rust 1.27. AFAICT there is no good reason to leave those as stabilized (we got lucky I guess), and while we could unstabilize them, it seems that they are worth stabilizing right after, so that would just introduce unnecessary churn.

It seems that when we stabilized the ADX intrinsics, we just forgot to also stabilize the ADX target feature attribute.

r? @alexcrichton

cc @jethrogb @Centril @rust-lang/libs (for the decision of not unstabilizing the accidentally stabilized intrinsics) @rust-lang/lang (for the decision of stabilizing the #[target_feature(enable = "adx,sse4a,tbm")] target features).

cc #44839 - tracking issue for target feature

gnzlbg · 2019-04-19T09:31:48Z

The ui tests will probably need updating. Also, I'm not sure if Rust 1.35.0 is the right version to use here.

Centril · 2019-04-19T13:41:33Z

@gnzlbg Looks good, tho the docs of https://doc.rust-lang.org/nightly/core/arch/x86_64/fn._mm_stream_ss.html could be a bit more illuminating for the unfamiliar but curious reader. MSDN provides more elaboration: https://docs.microsoft.com/en-us/cpp/intrinsics/mm-stream-ss?view=vs-2019.

An idea for the future: Can we feasibly link to the relevant vendor documentation for each function, e.g. Intel's docs for a specific intrinsic?

Also, the current nightly is 1.36 so 1.35 seems wrong?

@alexcrichton shall we start FCP?

alexcrichton · 2019-04-19T15:04:19Z

@rfcbot fcp merge

rfcbot · 2019-04-19T15:04:20Z

jethrogb · 2019-04-19T16:13:12Z

Can we feasibly link to the relevant vendor documentation for each function, e.g. Intel's docs for a specific intrinsic?

Not really. Intel provides two types of documentation: the intrinsics guide, which is often not very informative, and the software developer's manual, which is a many-1000 page PDF document, so it's not easy to link to.

gnzlbg · 2019-04-20T07:29:58Z

Agree with @jethrogb . In this case, SSE4a is not an Intel intrinsic, but an AMD one, and AMD does the exact same thing (1000s of pages long pdfs). These pdfs are not designed with tools that want to parse them in mind, so I don't think it's a feasible thing to do.

The Intel Intrinsics guide is available in XML format, and we do parse that for automatic verification of the intrinsics names/type signatures/instructions/etc. but the docs in there are not very good. The clang docs are better, and the MSVC docs are even better (they often contain working examples for each intrinsic), so maybe we could automatically parse those and use them to generate documentation (at least under the assumption that we could sort out licensing issues).

If somebody wants to work on doing this I'll be very happy to mentor.

gnzlbg · 2019-04-20T07:31:17Z

Also, the current nightly is 1.36 so 1.35 seems wrong?

I'll fix the tests and set this to 1.36.0!

bors · 2019-04-30T18:12:44Z

☔ The latest upstream changes (presumably #60416) made this pull request unmergeable. Please resolve the merge conflicts.

nikomatsakis · 2019-05-09T19:50:31Z

NB: I checked @aturon's box as he is presently on leave.

rfcbot · 2019-05-09T19:50:34Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2019-05-19T19:54:30Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

alexcrichton · 2019-05-20T14:02:54Z

@gnzlbg want to rebase and I'll r+?

Centril · 2019-05-27T07:09:46Z

When you rebase, remember to adjust the stabilization dates to 1.37.0.

mati865 · 2019-07-19T13:04:45Z

This has slipped to 1.38 and there is a conflict.

wirelessringo · 2019-07-26T09:11:58Z

Ping from triage @gnzlbg any updates on this?

JohnTitor · 2019-08-04T07:28:51Z

Ping from triage: @gnzlbg, you should resolve conflict and bump up the target version to 1.38.

JohnTitor · 2019-08-25T04:47:04Z

Ping from triage: @gnzlbg, you should resolve conflicts and bump up the target version to 1.39.

hdhoang · 2019-09-06T01:45:46Z

Ping from triage @gnzlbg, thank you for your work on this, please re-open this PR once you can resolve the conflicts (please re-open first then push).

dnrusakov · 2019-09-14T17:19:38Z

@gnzlbg Are you still planning to finish this work?

This is a continuation of rust-lang#60109, which noted that while the ADX intrinsics were stabilized, the corresponding target feature never was. This PR follows the same general structure and stabilizes the ADX target feature.

Stabilize ADX target feature This is a continuation of rust-lang#60109, which noted that while the ADX intrinsics were stabilized, the corresponding target feature never was. This PR follows the same general structure and stabilizes the ADX target feature. See also rust-lang#44839 - tracking issue for target feature

rust-highfive assigned alexcrichton Apr 19, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2019

This comment has been minimized.

Sign in to view

Centril added relnotes Marks issues that should be documented in the release notes of the next release. T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 19, 2019

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Apr 19, 2019

Centril added this to the 1.36 milestone Apr 22, 2019

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels May 9, 2019

rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label May 19, 2019

rfcbot removed the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label May 19, 2019

Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2019

Centril modified the milestones: 1.36, 1.37 May 27, 2019

gnzlbg force-pushed the stabilize_target_features branch from f6059b1 to 672d0e6 Compare June 22, 2019 14:22

Centril modified the milestones: 1.37, 1.38 Jul 2, 2019

Centril modified the milestones: 1.38, 1.39 Aug 13, 2019

hdhoang closed this Sep 6, 2019

hdhoang added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 6, 2019

Centril removed this from the 1.39 milestone Sep 26, 2019

Amanieu mentioned this pull request Feb 20, 2020

is_x86_feature_detected!("avx512f") fails to build on beta and nightly #68905

Closed

tarcieri mentioned this pull request Feb 6, 2022

crypto-intrinsics RustCrypto/utils#730

Closed

tarcieri mentioned this pull request Feb 7, 2022

Stabilize ADX target feature #93745

Merged

tarcieri mentioned this pull request Feb 8, 2022

Tracking issue for RFC 2045: improving #[target_feature] #44839

Open

22 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize ADX, TBM, and SSE4a target features #60109

Stabilize ADX, TBM, and SSE4a target features #60109

gnzlbg commented Apr 19, 2019

gnzlbg commented Apr 19, 2019 •

edited

Loading

This comment has been minimized.

Centril commented Apr 19, 2019

alexcrichton commented Apr 19, 2019

rfcbot commented Apr 19, 2019 •

edited by nikomatsakis

Loading

jethrogb commented Apr 19, 2019

gnzlbg commented Apr 20, 2019 •

edited

Loading

gnzlbg commented Apr 20, 2019

bors commented Apr 30, 2019

nikomatsakis commented May 9, 2019

rfcbot commented May 9, 2019

rfcbot commented May 19, 2019

alexcrichton commented May 20, 2019

Centril commented May 27, 2019

mati865 commented Jul 19, 2019 •

edited

Loading

wirelessringo commented Jul 26, 2019

JohnTitor commented Aug 4, 2019

JohnTitor commented Aug 25, 2019

hdhoang commented Sep 6, 2019

dnrusakov commented Sep 14, 2019

Stabilize ADX, TBM, and SSE4a target features #60109

Stabilize ADX, TBM, and SSE4a target features #60109

Conversation

gnzlbg commented Apr 19, 2019

gnzlbg commented Apr 19, 2019 • edited Loading

This comment has been minimized.

Centril commented Apr 19, 2019

alexcrichton commented Apr 19, 2019

rfcbot commented Apr 19, 2019 • edited by nikomatsakis Loading

jethrogb commented Apr 19, 2019

gnzlbg commented Apr 20, 2019 • edited Loading

gnzlbg commented Apr 20, 2019

bors commented Apr 30, 2019

nikomatsakis commented May 9, 2019

rfcbot commented May 9, 2019

rfcbot commented May 19, 2019

alexcrichton commented May 20, 2019

Centril commented May 27, 2019

mati865 commented Jul 19, 2019 • edited Loading

wirelessringo commented Jul 26, 2019

JohnTitor commented Aug 4, 2019

JohnTitor commented Aug 25, 2019

hdhoang commented Sep 6, 2019

dnrusakov commented Sep 14, 2019

gnzlbg commented Apr 19, 2019 •

edited

Loading

rfcbot commented Apr 19, 2019 •

edited by nikomatsakis

Loading

gnzlbg commented Apr 20, 2019 •

edited

Loading

mati865 commented Jul 19, 2019 •

edited

Loading