Do not ICE on incorrect const generic #60281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
estebank
commented
Apr 25, 2019
| @@ -541,6 +541,8 @@ impl<'a, 'gcx, 'tcx> SubstFolder<'a, 'gcx, 'tcx> { | |||
| let opt_ty = self.substs.get(p.idx as usize).map(|k| k.unpack()); | |||
| let ty = match opt_ty { | |||
| Some(UnpackedKind::Type(ty)) => ty, | |||
| Some(UnpackedKind::Const(ty::Const { ty, ..})) => ty, | |||
| None => source_ty, | |||
There was a problem hiding this comment.
This is incredibly suspect, but it is the branch that does fail (I think after adding the one above).
We could replace it with a delay_span_bug instead.
There was a problem hiding this comment.
I think this hides the issue without actually fixing it. What we want to do is forbid const parameters to have type parameters as their types. These used to be forbidden, but it hasn't been merged yet.
|
I think #60284 is the correct fix for this issue. Thanks for looking into it, though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #60264.
r? @varkor