Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICE with inconsistent macro matchers #61046

Merged
merged 2 commits into from
May 23, 2019
Merged

Conversation

mark-i-m
Copy link
Member

@mark-i-m
Copy link
Member Author

This may also want to be backported

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 22, 2019
@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 22, 2019

📌 Commit 5a9de55 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2019
@petrochenkov petrochenkov added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 22, 2019
@Centril Centril added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 23, 2019
@Centril
Copy link
Contributor

Centril commented May 23, 2019

@petrochenkov Please remember to add a team to the beta-nominated tag as well.

Centril added a commit to Centril/rust that referenced this pull request May 23, 2019
bors added a commit that referenced this pull request May 23, 2019
Rollup of 7 pull requests

Successful merges:

 - #60981 (Bump compiler-builtins to 0.1.15)
 - #61014 (Make -Zemit-artifact-notifications also emit the artifact type)
 - #61043 (Disable LLVM/debug assertions in gnu-full-bootstrap)
 - #61046 (Fix ICE with inconsistent macro matchers)
 - #61055 (Solaris CI: Build with dilos2 stable)
 - #61057 (Revert "Add implementations of last in terms of next_back on a bunch of DoubleEndedIterators.")
 - #61073 (librustc_errors: Remove unused annotation style `OldSchoolNoteText`)

Failed merges:

r? @ghost
@bors bors merged commit 5a9de55 into rust-lang:master May 23, 2019
@pnkfelix
Copy link
Member

approved for beta-backport.

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 23, 2019
@mark-i-m
Copy link
Member Author

@pnkfelix Is someone else already doing that? I might be able to do it, if you tell me how.

@Centril
Copy link
Contributor

Centril commented May 23, 2019

I assume @pietroalbini will do a backport rollup later.

@mark-i-m mark-i-m deleted the transcribe-fix branch May 25, 2019 02:15
@mark-i-m mark-i-m restored the transcribe-fix branch May 25, 2019 02:15
@mark-i-m mark-i-m deleted the transcribe-fix branch May 25, 2019 02:15
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 28, 2019
bors added a commit that referenced this pull request May 29, 2019
[beta] Rollup backports

Rolled up:

* [beta] adjust deprecation date of mem::uninitialized #61160

Cherry-picked:

* Fix ICE with inconsistent macro matchers #61046
* Revert "Add implementations of last in terms of next_back on a bunch of DoubleEndedIterators." #61057
* debuginfo: Revert to old/more verbose behavior for -Cdebuginfo=1 #61007

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent macro repeat operator leads to panic on nightly
7 participants