Linker improvements #6105
Closed
Linker improvements #6105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The motivation for this was a person on IRC (@ssbr) that was running into difficulties integrating rust into the distutils python build. Other use cases are allowing for custom linker scripts and choosing libraries without encoding them into the crate itself. |
|
Thanks! |
|
I've changed the names of the flags. I'm also not sure how to test the change, any suggestions for starting points? |
bors
added a commit
that referenced
this pull request
May 1, 2013
Adds two extra flags: `--linker` which takes extra flags to pass to the linker, can be used multiple times and `--print-link-args` which prints out linker arguments. Currently `--print-link-args` needs execution to get past translation to get the `LinkMeta` data. I haven't done tests or updated any extra documentation yet, so this pull request is currently here for review.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 9, 2020
Lint for invisible Unicode characters other than ZWSP
This PR extends the existing `zero_width_space` lint to look for other invisible characters as well (in this case, `\\u{ad}` soft hyphen.
I feel like this lint is the logical place to add the check, but I also realize the lint name is not particularly flexible, but I also understand that it shouldn't be renamed for compatibility reasons.
Open questions:
- What other characters should trigger the lint?
- What should be done with the lint name?
- How to indicate the change in functionality?
Motivation behind this PR: rust-lang#77417 - I managed to shoot myself in the foot by an invisible character pasted into my test case.
changelog: rename [`zero_width_space`] to [`invisible_characters`] and add SHY and WJ to the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two extra flags:
--linkerwhich takes extra flags to pass to the linker, can be used multiple times and--print-link-argswhich prints out linker arguments. Currently--print-link-argsneeds execution to get past translation to get theLinkMetadata.I haven't done tests or updated any extra documentation yet, so this pull request is currently here for review.