Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #61713

Closed
wants to merge 26 commits into from
Closed

Commits on Apr 12, 2019

  1. Configuration menu
    Copy the full SHA
    a4a07e0 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2019

  1. Configuration menu
    Copy the full SHA
    97a5173 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4419af8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cc17dbb View commit details
    Browse the repository at this point in the history
  4. Remove SyntaxExtension::DeclMacro

    It's a less powerful duplicate of `SyntaxExtension::NormalTT`
    petrochenkov committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    fa48a02 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a9397fd View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2019

  1. Configuration menu
    Copy the full SHA
    48d2c0b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f1867c5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5377dea View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a0e3e9a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    647b4a4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7bb0a16 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f11e6f7 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2019

  1. Configuration menu
    Copy the full SHA
    00f8f82 View commit details
    Browse the repository at this point in the history
  2. replace some mode comparisons by more readable function call, rename …

    …some Mode, and more comments
    RalfJung committed Jun 9, 2019
    Configuration menu
    Copy the full SHA
    5aaf72f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7e96bd0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4dbd279 View commit details
    Browse the repository at this point in the history
  5. comments

    RalfJung committed Jun 9, 2019
    Configuration menu
    Copy the full SHA
    38c7f3e View commit details
    Browse the repository at this point in the history
  6. submodules: update clippy from 71be6f6 to c0dbd34

    Changes:
    ````
    travis: disable rls integration test.
    rustup rust-lang#61669
    Add OUTER_EXPN_INFO lint
    ````
    matthiaskrgr committed Jun 9, 2019
    Configuration menu
    Copy the full SHA
    1d04514 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. Special-case literals in parse_bottom_expr.

    This makes parsing faster, particularly for code with large constants,
    for two reasons:
    - it skips all the keyword comparisons for literals;
    - it replaces the unnecessary `parse_literal_maybe_minus` call with
      `parse_lit`, avoiding an unnecessary allocation via `mk_expr`.
    nnethercote committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    35b5f43 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#59600 - tobia:master, r=pnkfelix

    Replaced linear token counting macros with optimized implementation
    
    There are currently two distinct token-counting macros in the source. Both implement the trivial algorithm, with linear complexity. They may or may not be adequate for their use case, but considering that other people are probably going to copy and paste them whenever they need a token-counting macro, I replaced them with an optimized implementation with logarithmic complexity.
    Centril authored Jun 10, 2019
    Configuration menu
    Copy the full SHA
    cdfbf14 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#61492 - RalfJung:const-qualif-comments, r=e…

    …ddyb
    
    Const qualification comments
    
    I extracted some const-qualif knowledge from @eddyb. This is my attempt to turn that into comments.
    
    Cc @oli-obk 	@eddyb
    Centril authored Jun 10, 2019
    Configuration menu
    Copy the full SHA
    02d8876 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#61570 - varkor:infer-const-arg, r=eddyb

    Fix issues with const argument inference
    
    Fixes rust-lang#60724.
    Fixes rust-lang#61346.
    
    r? @eddyb
    Centril authored Jun 10, 2019
    Configuration menu
    Copy the full SHA
    050262a View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#61606 - petrochenkov:legclean, r=pnkfelix

    Remove some legacy proc macro flavors
    
    Namely
    - `IdentTT` (`foo! ident { ... }`). Can be replaced with `foo! { ident ... }` or something similar.
    - `MultiDecorator`. Can be replaced by `MultiModifier` (aka `LegacyAttr` after renaming).
    - `DeclMacro`. It was a less powerful duplicate of `NormalTT` (aka `LegacyBang` after renaming) and can be replaced by it.
    
    Stuff like this slows down any attempts to refactor the expansion infra, so it's desirable to retire it already.
    I'm not sure whether a lang team decision is necessary, but would be nice to land this sooner because I have some further work in this area scheduled.
    
    The documentation commit (rust-lang@a9397fd) describes how the remaining variants are different from each other and shows that there's actually some system behind them.
    
    The last commit renames variants of `SyntaxExtension` in more systematic way.
    - `ProcMacro` -> `Bang`
    - `NormalTT` -> `LegacyBang`
    - `AttrProcMacro` -> `Attr`
    - `MultiModifier` -> `LegacyAttr`
    - `ProcMacroDerive` -> `Derive`
    - `BuiltinDerive` -> `LegacyDerive`
    
    All the `Legacy*` variants are AST-based, as opposed to "modern" token-based variants.
    Centril authored Jun 10, 2019
    Configuration menu
    Copy the full SHA
    78c326f View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#61612 - nnethercote:improve-parse_bottom_ex…

    …pr, r=petrochenkov
    
    Special-case literals in `parse_bottom_expr`.
    
    This makes parsing faster, particularly for code with large constants,
    for two reasons:
    - it skips all the keyword comparisons for literals;
    - it skips the allocation done by the `mk_expr` call in
      `parse_literal_maybe_minus`.
    
    r? @petrochenkov
    Centril authored Jun 10, 2019
    Configuration menu
    Copy the full SHA
    965e75a View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#61697 - matthiaskrgr:submodule_upd, r=Manis…

    …hearth
    
    submodules: update clippy from 71be6f6 to c0dbd34
    
    Changes:
    ````
    travis: disable rls integration test.
    rustup rust-lang#61669
    Add OUTER_EXPN_INFO lint
    ````
    
    Should fix clippy toolstate
    Centril authored Jun 10, 2019
    Configuration menu
    Copy the full SHA
    2679947 View commit details
    Browse the repository at this point in the history