#62357: doc(ptr): add example for {read,write}_unaligned #62493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Kimundi (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @RalfJung |
|
Thanks a lot! Also, this PR is marked as not-yet-ready-for-review? |
|
@ralfbiedert Yes I marked it has draft because it's one of my first PR, didn't know if I needed to do it before switching to "ready for review". |
|
Well, if you want it to be reviewed, then mark it as ready for that. :) |
|
@Freyskeyd I guess you mean @RalfJung :) |
Freyskeyd
force-pushed
the
valid_example_read-write_unaligned
branch
from
6750518
to
185dda3
Compare
tesuji
reviewed
Jul 8, 2019
Freyskeyd
force-pushed
the
valid_example_read-write_unaligned
branch
from
185dda3
to
7ef7e93
Compare
|
Thanks! CI is failing, though. From glancing at the logs it seems the problem is just that |
Signed-off-by: Freyskeyd <[email protected]>
Freyskeyd
force-pushed
the
valid_example_read-write_unaligned
branch
from
7ef7e93
to
bc322af
Compare
|
@rkruppe is it ok for you ? :) |
|
CI passes, that's good :) Thanks again! @bors r+ rollup |
|
📌 Commit bc322af has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 10, 2019
…unaligned, r=rkruppe rust-lang#62357: doc(ptr): add example for {read,write}_unaligned related to rust-lang#62357 > With rust-lang#62323 the only example (that had UB and was thus invalid) in std::ptr::read_unaligned and std::ptr::write_unaligned is removed. > We should add a valid example of using the aforementioned functions. Signed-off-by: Freyskeyd <[email protected]>
bors
added a commit
that referenced
this pull request
Jul 10, 2019
Rollup of 5 pull requests Successful merges: - #62275 (rustc_mir: treat DropAndReplace as Drop + Assign in qualify_consts.) - #62465 (Sometimes generate storage statements for temporaries with type `!`) - #62481 (Use `fold` in `Iterator::last` default implementation) - #62493 (#62357: doc(ptr): add example for {read,write}_unaligned) - #62532 (Some more cleanups to syntax::print) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Jul 10, 2019
Rollup of 5 pull requests Successful merges: - #62275 (rustc_mir: treat DropAndReplace as Drop + Assign in qualify_consts.) - #62465 (Sometimes generate storage statements for temporaries with type `!`) - #62481 (Use `fold` in `Iterator::last` default implementation) - #62493 (#62357: doc(ptr): add example for {read,write}_unaligned) - #62532 (Some more cleanups to syntax::print) Failed merges: r? @ghost
|
☔ The latest upstream changes (presumably #62561) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #62357
Signed-off-by: Freyskeyd [email protected]