Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unicode-xid crate instead of libcore #62848

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Use unicode-xid crate instead of libcore #62848

merged 2 commits into from
Sep 5, 2019

Commits on Sep 4, 2019

  1. remove XID and Pattern_White_Space unicode tables from libcore 

    They are only used by rustc_lexer, and are not needed elsewhere.

So we move the relevant definitions into rustc_lexer (while the actual
unicode data comes from the unicode-xid crate) and make the rest of
the compiler use it.
    @matklad
    matklad committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    a0c186c View commit details
    Browse the repository at this point in the history

  2. flatten rustc_lexer::character_properties module 

    On the call site, `rustc_lexer::is_whitespace` reads much better than
`character_properties::is_whitespace`.
    @matklad
    matklad committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    206fe8e View commit details
    Browse the repository at this point in the history