Rollup of 6 pull requests #63052
Closed
Rollup of 6 pull requests #63052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was left out by accident from the "convert everything to rlibs" commit, there's no need for this to be a dylib just as everything else doesn't need to be a dylib!
Co-Authored-By: Mazdak Farrokhzad <[email protected]>
Move `source_uitil` macros into `syntax_ext` Cleanup dependencies of `rustc_driver`
Few other minor renamings for consistency. Remove one unused dependency from `rustc_passes`. Fix libsyntax tests. Fix rebase.
`contents` is the whole file rather than a single line.
This fixes multiple network issues we had when downloading awscli from PyPI on Azure Pipelines by vendoring awscli itself and its dependencies in our S3 bucket. Instructions on how to update the cache are present at the top of src/ci/install-awscli.sh
…me-elision-2, r=Centril Allow lifetime elision in `Pin<&(mut) Self>` This PR changes `self: &(mut) S` elision rules to instead visit the type of `self` and look for `&(mut) S` (where `is_self_ty(S)`) within it Replaces rust-lang#60944 Closes rust-lang#52675 r? @eddyb cc @cramertj @Centril @withoutboats @scottmcm
Break dependencies between `syntax_ext` and other crates Move `source_util` macros into `syntax_ext`. Move other early code generation facilities like standard library injection into `syntax_ext`. The only crate that depends on `syntax_ext` now is `rustc_interface` which is one of the "final" crates that depend on everything. Minor: Cleanup dependencies of `rustc_driver`, many of them are no longer used after introduction of `rustc_interface`. r? @eddyb
…ulacrum rustc: Compile the `fmt_macros` crate as an rlib I think this was left out by accident from the "convert everything to rlibs" commit, there's no need for this to be a dylib just as everything else doesn't need to be a dylib!
Re-enable assertions in PPC dist builder Fixes rust-lang#36150 Log of successful build: https://dev.azure.com/mati865/6518b167-4cf6-4587-b3d1-8e137f2fb2e4/_apis/build/builds/23/logs/825
tidy: Add a check for inline unit tests As described in rust-lang#61097. There's a large whitelist right now, because in many crates the tests are not outlined yet. ~This PR only outlines tests in one crate (`rustc_lexer`) as an example.~ r? @Mark-Simulacrum
…Simulacrum ci: download awscli from our mirror This fixes multiple network issues we had when downloading awscli from PyPI on Azure Pipelines by vendoring awscli itself and its dependencies in our S3 bucket. Instructions on how to update the cache are present at the top of `src/ci/install-awscli.sh`. r? @alexcrichton or @Mark-Simulacrum fixes rust-lang#62967
|
@bors r+ p=200 rollup=never |
|
📌 Commit 6fcf96b has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 6fcf96b with merge 4b1b4eee5669b76e67ed64edadd5ca71e79da7f1... |
|
💔 Test failed - checks-azure |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Pin<&(mut) Self>#61207 (Allow lifetime elision inPin<&(mut) Self>)syntax_extand other crates #62771 (Break dependencies betweensyntax_extand other crates)fmt_macroscrate as an rlib #62813 (rustc: Compile thefmt_macroscrate as an rlib)Failed merges:
r? @ghost