WIP: Fix test style in unused parentheses lint test #63257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
I think the issue was just confusing the name of the file. According to a quick ripgrep, the other test using the |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
JohnTitor
reviewed
Aug 4, 2019
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
From the Azure CI logs: I set the argument to |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
So I understand I have to edit the corresponding Could someone lend me a hand with this, or give me some pointers? |
|
☔ The latest upstream changes (presumably #63341) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@monoflo usually the easiest way to get the |
JohnCSimon
added
S-waiting-on-author
|
Ping from triage |
|
Pinging again from triage |
|
(Note: you'll also want to run |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@monoflo great, thanks! can you rebase to remove the merge commit? |
|
ping from triage @monoflo, could you rebase so that only your commit appears in the "Commits" tab for this PR? Please feel free to reach out to us in #triage-wg on rust-lang Discord for more help. |
Updates test file to use `#![deny(unused_parens)]` and `//~ERROR` annotations instead of pretty-json. See: #63237
Updates test file to use `#![deny(unused_parens)]` and `//~ERROR` annotations instead of pretty-json. See: #63237
Set empty argument for `--error-format` to "json" Issue #63236 See: https://dev.azure.com/rust-lang/rust/_build/results?buildId=5110&view=logs
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
nikomatsakis
reviewed
Oct 3, 2019
There was a problem hiding this comment.
Maybe we should keep up the "pretty-json" too?
cc @bravomikekilo, who opened the original issue (I don't have a strong opinion here)
| @@ -1,5 +1,4 @@ | |||
| // compile-flags: --error-format pretty-json -Zunstable-options | |||
| // build-pass (FIXME(62277): could be check-pass?) | |||
| // compile-flags: --error-format json -Zunstable-options | |||
There was a problem hiding this comment.
it seems like pretty-json is more "diff friendly", even so, no?
|
Also: we are getting failures in the checks, are those maybe spurious? I couldn't get much from the logs. |
|
@monoflo any updates on this? |
|
second ping from triage @monoflo, thank you for your work on this. When you can continue, please re-open this PR first then push your updates. |
hdhoang
added
S-inactive
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 23, 2019
Fix test style in unused parentheses lint test I think this fixes rust-lang#63237 I'm not sure if I had to add text after the `//~ ERROR` comments. This is my first pull request, so I'm open to feedback. This issues already received one pull request [here](rust-lang#63257) but it was marked as closed for inactivity. r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is my first attempt at a pull request for the Rust project.
I'm fairly certain that I did this wrong, so I'm open to any and all feedback!
Per the issue, I was unable to find
test/lint/used_parens_remove_json_suggestion.rs. Is this a file I should create?Issue
#63237