-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #63395
Rollup of 6 pull requests #63395
Commits on Aug 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3bfb4c3 - Browse repository at this point
Copy the full SHA 3bfb4c3View commit details
Commits on Aug 8, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b9978e9 - Browse repository at this point
Copy the full SHA b9978e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2af718 - Browse repository at this point
Copy the full SHA b2af718View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58c231d - Browse repository at this point
Copy the full SHA 58c231dView commit details -
move of packed fields might or might not occur when they actually are…
… sufficiently aligned
Configuration menu - View commit details
-
Copy full SHA for e82b053 - Browse repository at this point
Copy the full SHA e82b053View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cea446 - Browse repository at this point
Copy the full SHA 9cea446View commit details -
Co-Authored-By: Vadim Petrochenkov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fcb186d - Browse repository at this point
Copy the full SHA fcb186dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06701a8 - Browse repository at this point
Copy the full SHA 06701a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4a654d - Browse repository at this point
Copy the full SHA c4a654dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ffb5f18 - Browse repository at this point
Copy the full SHA ffb5f18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78b6580 - Browse repository at this point
Copy the full SHA 78b6580View commit details -
Configuration menu - View commit details
-
Copy full SHA for 946bed8 - Browse repository at this point
Copy the full SHA 946bed8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d49118 - Browse repository at this point
Copy the full SHA 2d49118View commit details -
Configuration menu - View commit details
-
Copy full SHA for 295f894 - Browse repository at this point
Copy the full SHA 295f894View commit details -
Configuration menu - View commit details
-
Copy full SHA for ceda774 - Browse repository at this point
Copy the full SHA ceda774View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05aa983 - Browse repository at this point
Copy the full SHA 05aa983View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03de7fd - Browse repository at this point
Copy the full SHA 03de7fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82b3b82 - Browse repository at this point
Copy the full SHA 82b3b82View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6be1d7 - Browse repository at this point
Copy the full SHA e6be1d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bde056 - Browse repository at this point
Copy the full SHA 4bde056View commit details -
Configuration menu - View commit details
-
Copy full SHA for 798767c - Browse repository at this point
Copy the full SHA 798767cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa58c27 - Browse repository at this point
Copy the full SHA fa58c27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48fbf48 - Browse repository at this point
Copy the full SHA 48fbf48View commit details -
Rollup merge of rust-lang#63162 - RalfJung:miri-xargo, r=alexcrichton
Miri tests: use xargo to build separate libstd This uses `cargo miri setup` to prepare the libstd that is used for testing Miri, instead of adjusting the entire bootstrap process to make sure the libstd that already gets built is fit for Miri. The issue with our current approach is that with `test-miri = true`, libstd and the test suite get built with `--cfg miri`, which e.g. means hashbrown uses no SIMD, and not all things are tested. Such global side-effects seem like footguns waiting to go off. On the other hand, the new approach means we install xargo as a side-effect of doing `./x.py test src/tools/miri`, which might be surprising, and we also both have to build xargo and another libstd which costs some extra time. Not sure if the tools builders have enough time budget for that. Maybe there is a way to cache xargo? We have to first first land rust-lang/miri#870 in Miri and then update this PR to include that change (also to get CI to test Miri before bors), but I wanted to get the review started here. Cc @oli-obk (for Miri) @alexcrichton (for CI) @Mark-Simulacrum (for bootstrap) Fixes rust-lang#61833, fixes rust-lang#63219
Configuration menu - View commit details
-
Copy full SHA for fea43aa - Browse repository at this point
Copy the full SHA fea43aaView commit details -
Rollup merge of rust-lang#63289 - kornelski:missingcrate, r=zackmdavis
Don't recommend `extern crate` syntax `extern crate` syntax is not a good recommendation any more, so I've changed it to just print a suggested crate name.
Configuration menu - View commit details
-
Copy full SHA for 74b22c9 - Browse repository at this point
Copy the full SHA 74b22c9View commit details -
Rollup merge of rust-lang#63373 - RalfJung:gitignore, r=alexcrichton
gitignore: add comment explaining policy Based on rust-lang#63307 (comment), I added a comment what I think should be gitignored and what not. This is just a proposal, obviously. Also see rust-lang#53768 for some more discussion. The summary is that if there are junk files that you create locally and are fine leaving around (such as `mir_dump`), git has the option for you to add them to `.git/info/exclude`. Others might prefer to keep their working dir clean of those same junk files, so we shouldn't just ignore them for everyone. I then also cleaned up a few more things, but there were many things that I had no idea where they came from so I didn't touch them.
Configuration menu - View commit details
-
Copy full SHA for 82e9762 - Browse repository at this point
Copy the full SHA 82e9762View commit details -
Rollup merge of rust-lang#63374 - RalfJung:pin-packed, r=cramertj
move of packed fields might or might not occur when they actually are sufficiently aligned See taiki-e/pin-project#34, where it was pointed out that we actually don't move fields of 1-aligned types when dropping a packed struct -- but e.g. in a `packed(2)` struct, we don't do something similar for 2-aligned types. The code for that is [here](https://github.com/rust-lang/rust/blob/db7c773a6be2f050d1d1504763819ea3916f5428/src/librustc_mir/util/alignment.rs#L7).
Configuration menu - View commit details
-
Copy full SHA for 432b55e - Browse repository at this point
Copy the full SHA 432b55eView commit details -
Rollup merge of rust-lang#63381 - matklad:reduce-visibility, r=Centril
reduce visibility r? @petrochenkov
Configuration menu - View commit details
-
Copy full SHA for c9dd930 - Browse repository at this point
Copy the full SHA c9dd930View commit details -
Rollup merge of rust-lang#63387 - Centril:async-block-control-flow-te…
…sts, r=cramertj Test interaction between `async { ... }` and `?`, `return`, and `break` Per the second checkbox in rust-lang#62121 (comment), test that `async { .. }` blocks: 1. do not allow `break` expressions. 2. get targeted by `return` and not the parent function. 3. get targeted by `?` and not the parent function. Works towards resolving blockers in rust-lang#63209. r? @cramertj
Configuration menu - View commit details
-
Copy full SHA for 87fb0ad - Browse repository at this point
Copy the full SHA 87fb0adView commit details