Rollup of 8 pull requests #63465

Mark-Simulacrum · 2019-08-11T15:05:50Z

Successful merges:

Add #[repr(transparent)] for several types #61969 (Add #[repr(transparent)] for several types)
Use sharded maps for queries #62108 (Use sharded maps for queries)
resolve: Populate external modules in more automatic and lazy way #63149 (resolve: Populate external modules in more automatic and lazy way)
Lint on some incorrect uses of mem::zeroed / mem::uninitialized #63346 (Lint on some incorrect uses of mem::zeroed / mem::uninitialized)
Miri shouldn't look at types #63433 (Miri shouldn't look at types)
rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE #63440 (rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE)
Add an example to show how to insert item to a sorted vec #63442 (Add an example to show how to insert item to a sorted vec)
syntax: account for CVarArgs being in the argument list. #63459 (syntax: account for CVarArgs being in the argument list.)

Failed merges:

The modules are now populated implicitly on the first access

Curtesy of petrochenkov

Avoid using dummy spans for some external items with available spans

Add #[repr(transparent)] for several types In some functions, types mentioned in this PR are transmuted into their inner value. Example for `PathBuf`: https://github.com/rust-lang/rust/blob/master/src/libstd/path.rs#L1132. This PR adds `#[repr(transparent)]` to those types, so their correct behavior doesn't depend on compiler details. (As far as I understand, currently that line, converting `PathBuf` to `Vec<u8>`, is UB).

Use sharded maps for queries Based on rust-lang#61779. r? @gankro

@eddyb

resolve: Populate external modules in more automatic and lazy way So, resolve had this function `populate_module_if_necessary` for loading module children from other crates from metadata. I never really understood when it should've been called and when not. This PR removes the function and loads the module children automatically on the first access instead. r? @eddyb

Lint on some incorrect uses of mem::zeroed / mem::uninitialized Cc rust-lang#62825 and https://internals.rust-lang.org/t/make-mem-uninitialized-and-mem-zeroed-panic-for-some-types-where-0-is-a-niche/10605 This does not yet handle `NonNull`/`NonZero*`, but it is a start. I also improved some doc issues I hit on the way, and added a useful helper to `TyS`. EDIT: I added the relnotes label mostly as a proposal -- I think this is worth mentioning, but leave the decision up to the release team.

@oli-obk

Miri shouldn't look at types r? @oli-obk Fixes rust-lang#62137

rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE This matches `RUSTC_LOG`. Both affect only rustc, not any Rust program.

@Mark-Simulacrum

…k-Simulacrum Add an example to show how to insert item to a sorted vec Closes rust-lang#61684 cc rust-lang#61742 r? @Mark-Simulacrum, @jonas-schievink

@petrochenkov

syntax: account for CVarArgs being in the argument list. Fixes rust-lang#63430 by testing for `1` argument (the `CVarArgs` itself) instead of `0`. Note that the error has basically been impossible to trigger since the change that caused rust-lang#63430, so perhaps we need an audit of untested errors. Also, this check probably belongs in AST validation/HIR lowering, but I'd rather fix it in place for now. r? @petrochenkov cc @dlrobertson

Mark-Simulacrum · 2019-08-11T15:06:07Z

@bors r+ p=5

bors · 2019-08-11T15:06:08Z

📌 Commit 262394e has been approved by Mark-Simulacrum

bors · 2019-08-11T17:20:37Z

⌛ Testing commit 262394e with merge 2fa4624...

@ghost

Rollup of 8 pull requests Successful merges: - #61969 (Add #[repr(transparent)] for several types) - #62108 (Use sharded maps for queries) - #63149 (resolve: Populate external modules in more automatic and lazy way) - #63346 (Lint on some incorrect uses of mem::zeroed / mem::uninitialized) - #63433 (Miri shouldn't look at types) - #63440 (rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE) - #63442 (Add an example to show how to insert item to a sorted vec) - #63459 (syntax: account for CVarArgs being in the argument list.) Failed merges: r? @ghost

Mark-Simulacrum · 2019-08-11T19:14:57Z

@bors retry - canceling build (Bors seems to have not noticed that it failed)

bors · 2019-08-11T19:15:07Z

⌛ Testing commit 262394e with merge cb3efb1cbc5df732f59f62fa26bc67acd984b5be...

pietroalbini · 2019-08-14T07:06:45Z

@bors retry r-

RalfJung · 2019-08-14T07:06:52Z

@bors r-

Bors seems confused? This is currently listed as "pending"...

Zoxc and others added 28 commits July 26, 2019 05:24

Use sharded maps for queries

f84967f

Add FIXME-s that some types should be transparent

740f8db

Miri shouldn't look at types

03e95ae

fix test

62f1e8a

rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE

440a5c8

Add an example to show how to insert item to a sorted vec

93839c3

Use Result::unwrap_or_else instead of matching

30ba4bd

syntax: account for CVarArgs being in the argument list.

6b11a63

resolve: Populate external modules in more automatic and lazy way

a8017d6

The modules are now populated implicitly on the first access

resolve: Populate external traits lazily as well

aee4313

add basic lint testing for misuse of mem::zeroed and mem::uninitialized

da6fbb1

warn for more cases

ca1e94b

fix a comment

fbd5613

add tuple_fields convenience method and use it in a few places

8e6fbbe

note a FIXME

4b062a1

proper doc comment for 'recovered' field of variant

3972d05

Curtesy of petrochenkov

allow the lint if a few UB-demonstrating doc tests

c5a6356

note down some more future plans

5c77a17

update clippy

0930747

resolve: Move some code around

a087df6

Avoid using dummy spans for some external items with available spans

Rollup merge of rust-lang#62108 - Zoxc:sharded-queries, r=oli-obk

6381937

Use sharded maps for queries Based on rust-lang#61779. r? @gankro

Rollup merge of rust-lang#63433 - RalfJung:miri-call, r=oli-obk

63b4709

Miri shouldn't look at types r? @oli-obk Fixes rust-lang#62137

Rollup merge of rust-lang#63440 - RalfJung:ctfe-backtrace, r=oli-obk

9fbfab8

rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE This matches `RUSTC_LOG`. Both affect only rustc, not any Rust program.

Rollup merge of rust-lang#63442 - lzutao:vec-bin-search-insert, r=Mar…

93bd9ff

…k-Simulacrum Add an example to show how to insert item to a sorted vec Closes rust-lang#61684 cc rust-lang#61742 r? @Mark-Simulacrum, @jonas-schievink

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 11, 2019

Mark-Simulacrum closed this Aug 11, 2019

Mark-Simulacrum deleted the rollup-bq3u7tz branch August 11, 2019 19:15

Mark-Simulacrum mentioned this pull request Aug 11, 2019

resolve: Populate external modules in more automatic and lazy way #63149

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 14, 2019

Centril added the rollup A PR which is a rollup label Oct 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #63465

Rollup of 8 pull requests #63465

Mark-Simulacrum commented Aug 11, 2019

Mark-Simulacrum commented Aug 11, 2019

bors commented Aug 11, 2019

bors commented Aug 11, 2019

Mark-Simulacrum commented Aug 11, 2019

bors commented Aug 11, 2019

pietroalbini commented Aug 14, 2019

RalfJung commented Aug 14, 2019

Rollup of 8 pull requests #63465

Rollup of 8 pull requests #63465

Conversation

Mark-Simulacrum commented Aug 11, 2019

Mark-Simulacrum commented Aug 11, 2019

bors commented Aug 11, 2019

bors commented Aug 11, 2019

Mark-Simulacrum commented Aug 11, 2019

bors commented Aug 11, 2019

pietroalbini commented Aug 14, 2019

RalfJung commented Aug 14, 2019