Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove meaningless comments in src/test #63487

Merged
merged 3 commits into from
Aug 18, 2019
Merged

Remove meaningless comments in src/test #63487

merged 3 commits into from
Aug 18, 2019

Conversation

sd234678
Copy link
Contributor

@sd234678 sd234678 commented Aug 12, 2019 •
edited
Loading

Moved from #63411

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 12, 2019
@sd234678 sd234678 mentioned this pull request Aug 12, 2019
Closed
@sd234678
Copy link
Contributor Author

r? @Centril

Centril
Centril approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me rollup when green

@Centril
Copy link
Contributor

Centril commented Aug 13, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 13, 2019

📌 Commit 7fb5eb528ef30dbfc2c052314ae025d239b4ad02 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2019
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Aug 14, 2019
Closed
@bors
Copy link
Contributor

bors commented Aug 14, 2019

☔ The latest upstream changes (presumably #63544) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 14, 2019
@Centril
Copy link
Contributor

Centril commented Aug 15, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Aug 15, 2019

📌 Commit 5f50c4a has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 15, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 15, 2019
@Centril
Rollup merge of rust-lang#63487 - sd234678:remove-meaningless-comment…
bb62270 
…s-in-src/test-2, r=Centril

Remove meaningless comments in src/test

Moved from rust-lang#63411
@Centril Centril mentioned this pull request Aug 15, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Aug 16, 2019

Failed in #63617 (comment), @bors r-
You'll also need --bless --compare-mode=nll.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 16, 2019
@sd234678
Copy link
Contributor Author

@Centril do I need to do anything else to get bors to pick this back up?

@Centril
Copy link
Contributor

Centril commented Aug 17, 2019

@sd234678 I need to reapprove the PR when you make a change. However, when you force-push I don't get a notification so you have to leave a comment instead if you want me to see it.

@bors r+

@bors
Copy link
Contributor

bors commented Aug 17, 2019

📌 Commit b21ee49 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 17, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 17, 2019
@Centril
Rollup merge of rust-lang#63487 - sd234678:remove-meaningless-comment…
a396434 
…s-in-src/test-2, r=Centril

Remove meaningless comments in src/test

Moved from rust-lang#63411
@Centril Centril mentioned this pull request Aug 17, 2019
Merged
bors added a commit that referenced this pull request Aug 17, 2019
@bors
Auto merge of #63671 - Centril:rollup-zufavt5, r=Centril
bd1da18 
Rollup of 5 pull requests

Successful merges:

 - #62451 (Add APIs for uninitialized Box, Rc, and Arc. (Plus get_mut_unchecked))
 - #63487 (Remove meaningless comments in src/test)
 - #63657 (Crank up invalid value lint)
 - #63667 (resolve: Properly integrate derives and `macro_rules` scopes)
 - #63669 (fix typos in mir/interpret)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Aug 18, 2019

☔ The latest upstream changes (presumably #63671) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 18, 2019
@bors bors merged commit b21ee49 into rust-lang:master Aug 18, 2019
@sd234678 sd234678 deleted the remove-meaningless-comments-in-src/test-2 branch August 19, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril approved these changes

Assignees

@Centril Centril

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sd234678 @rust-highfive @Centril @bors @nikomatsakis