Remove uses of mem::uninitialized() from cloudabi
#63546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Aug 14, 2019
RalfJung
reviewed
Aug 14, 2019
|
This looks good other than the nits, but I know nothing about CloudABI. @alexcrichton can I just r+ this when it looks reasonable, or what do we do with exotic platforms? |
|
Before it's too late, let's fix the typo in the commit message and PR title, should one day people grep the revision log for archaeology... |
tesuji
force-pushed
the
clouldabi-maybeuninit
branch
from
1883b89
to
d5bedf5
Compare
tesuji
changed the title
mem::uninitialized() from clouldabimem::uninitialized() from cloudabi
|
Yes this is fine to r+ when ready, the maintainer (@EdSchouten) has been cc'd so we can wait a bit for them to take a look but otherwise we don't strictly review these platforms. |
|
☔ The latest upstream changes (presumably #63534) made this pull request unmergeable. Please resolve the merge conflicts. |
tesuji
force-pushed
the
clouldabi-maybeuninit
branch
from
d5bedf5
to
b49c0db
Compare
|
@lzutao force-pushes don't trigger notifications, so please let the reviewer know when you did them so that they can take another look. |
RalfJung
reviewed
Aug 15, 2019
tesuji
force-pushed
the
clouldabi-maybeuninit
branch
from
b49c0db
to
6e8639a
Compare
|
@bors r+ |
|
📌 Commit 6e8639a has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
…fJung Remove uses of `mem::uninitialized()` from cloudabi This PR removes uses of `mem::uninitialized` from `cloudabi` module, excluding the layout test in `src/libstd/sys/cloudabi/abi/cloudabi.rs`. r? @RalfJung cc @EdSchouten cc rust-lang#62397
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
…fJung Remove uses of `mem::uninitialized()` from cloudabi This PR removes uses of `mem::uninitialized` from `cloudabi` module, excluding the layout test in `src/libstd/sys/cloudabi/abi/cloudabi.rs`. r? @RalfJung cc @EdSchouten cc rust-lang#62397
bors
added a commit
that referenced
this pull request
Aug 15, 2019
Rollup of 9 pull requests Successful merges: - #63155 (Add UWP MSVC targets) - #63165 (Add builtin targets for mips64(el)-unknown-linux-muslabi64) - #63306 (Adapt AddRetag for shallow retagging) - #63467 (Add Catalyst (iOS apps running on macOS) target) - #63546 (Remove uses of `mem::uninitialized()` from cloudabi) - #63572 (remove unused Level::PhaseFatal) - #63577 (Test HRTB issue accepted by compiler) - #63582 (Fix ICE #63226) - #63586 (cleanup: Remove `Spanned` where possible) Failed merges: r? @ghost
|
☔ The latest upstream changes (presumably #63592) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes uses of
mem::uninitializedfromcloudabimodule,excluding the layout test in
src/libstd/sys/cloudabi/abi/cloudabi.rs.r? @RalfJung
cc @EdSchouten
cc #62397