Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_gate: Remove dead code from attribute checking #64462

Merged
merged 3 commits into from
Sep 15, 2019

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Sep 14, 2019

#63468 is merged, so all attributes go through name resolution now, so we can remove code that previously performed some checks for attributes not going through resolution.

Same checks are performed during name resolution, and all attributes go through name resolution now
Use `PostExpansionVisitor` directly instead
@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2019
@petrochenkov
Copy link
Contributor Author

cc @c410-f3r

parse_sess: &'a ParseSess,
plugin_attributes: &'a [(Symbol, AttributeType)],
}

macro_rules! gate_feature_fn {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: In a follow-up, I think we should consider making this infra not use macros since it tends to be infectious atm and not very readable.

@Centril
Copy link
Contributor

Centril commented Sep 14, 2019

Nice! r? @Centril @bors r+

@bors
Copy link
Contributor

bors commented Sep 14, 2019

📌 Commit cb771fd has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned eddyb Sep 14, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 14, 2019
feature_gate: Remove dead code from attribute checking

rust-lang#63468 is merged, so all attributes go through name resolution now, so we can remove code that previously performed some checks for attributes not going through resolution.
bors added a commit that referenced this pull request Sep 14, 2019
Rollup of 4 pull requests

Successful merges:

 - #61797 (Stabilise weak_ptr_eq)
 - #64290 (Provide a span if main function is not present in crate)
 - #64406 (Ban non-extern rust intrinsics)
 - #64462 (feature_gate: Remove dead code from attribute checking)

Failed merges:

r? @ghost
@bors bors merged commit cb771fd into rust-lang:master Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants