Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: Improve output of dist step #64618

Merged
merged 1 commit into from
Sep 22, 2019
Merged

rustbuild: Improve output of dist step #64618

merged 1 commit into from
Sep 22, 2019

Conversation

alexcrichton
Copy link
Member

  • Pass /Q to iscc on Windows to supress the thousands of lines of
    output about compressing documentation.
  • Print out what's happening before long steps
  • Use timeit to print out timing information for long-running
    installer assemblies.
  • Try to scope output of Dist ... to not also encompass actual build steps

@alexcrichton
rustbuild: Improve output of dist step
255dd3f 
* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
  output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
  installer assemblies.
@alexcrichton
Copy link
Member Author

r? @Mark-Simulacrum

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2019
@Mark-Simulacrum
Copy link
Member

@bors r+

  • Pass /Q to iscc on Windows to supress the thousands of lines of
    output about compressing documentation.

This won't silence errors, right? I guess even if it does, we probably haven't seen an error here in ages so doesn't matter too much.

@bors
Copy link
Contributor

bors commented Sep 19, 2019

📌 Commit 255dd3f has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 20, 2019
@Centril
Rollup merge of rust-lang#64618 - alexcrichton:improve-dist-output, r…
0c5f9a9 
…=Mark-Simulacrum

rustbuild: Improve output of `dist` step

* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
  output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
  installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@Centril Centril mentioned this pull request Sep 20, 2019
Closed
bors added a commit that referenced this pull request Sep 20, 2019
@bors
Auto merge of #64626 - Centril:rollup-elbvzz0, r=Centril
c59bea3 
Rollup of 8 pull requests

Successful merges:

 - #64136 (Document From trait for LhsExpr in parser)
 - #64342 (factor out pluralisation remains after #64280)
 - #64387 (Fix redundant semicolon lint interaction with proc macro attributes)
 - #64498 (When possible point at argument causing item obligation failure)
 - #64615 (rustbuild: Turn down compression on exe installers)
 - #64617 (rustbuild: Turn down compression on msi installers)
 - #64618 (rustbuild: Improve output of `dist` step)
 - #64621 (Add Compatibility Notes to RELEASES.md for 1.38.0)

Failed merges:

r? @ghost
@alexcrichton
Copy link
Member Author

According to this at least /Q should still print errors

Centril added a commit to Centril/rust that referenced this pull request Sep 20, 2019
@Centril
Rollup merge of rust-lang#64618 - alexcrichton:improve-dist-output, r…
4a75154 
…=Mark-Simulacrum

rustbuild: Improve output of `dist` step

* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
  output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
  installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@Centril Centril mentioned this pull request Sep 20, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Sep 20, 2019
@tmandry
Rollup merge of rust-lang#64618 - alexcrichton:improve-dist-output, r…
aa3dc06 
…=Mark-Simulacrum

rustbuild: Improve output of `dist` step

* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
  output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
  installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@tmandry tmandry mentioned this pull request Sep 20, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Sep 20, 2019
@tmandry
Rollup merge of rust-lang#64618 - alexcrichton:improve-dist-output, r…
5c10773 
…=Mark-Simulacrum

rustbuild: Improve output of `dist` step

* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
  output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
  installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@tmandry tmandry mentioned this pull request Sep 20, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Sep 20, 2019
@tmandry
Rollup merge of rust-lang#64618 - alexcrichton:improve-dist-output, r…
8896f79 
…=Mark-Simulacrum

rustbuild: Improve output of `dist` step

* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
  output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
  installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@tmandry tmandry mentioned this pull request Sep 20, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Sep 20, 2019
@tmandry
Rollup merge of rust-lang#64618 - alexcrichton:improve-dist-output, r…
572fc82 
…=Mark-Simulacrum

rustbuild: Improve output of `dist` step

* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
  output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
  installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@tmandry tmandry mentioned this pull request Sep 20, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Sep 21, 2019
@tmandry
Rollup merge of rust-lang#64618 - alexcrichton:improve-dist-output, r…
a5c7e68 
…=Mark-Simulacrum

rustbuild: Improve output of `dist` step

* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
  output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
  installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@tmandry tmandry mentioned this pull request Sep 21, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Sep 21, 2019
@Centril
Rollup merge of rust-lang#64618 - alexcrichton:improve-dist-output, r…
ef86303 
…=Mark-Simulacrum

rustbuild: Improve output of `dist` step

* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
  output about compressing documentation.
* Print out what's happening before long steps
* Use `timeit` to print out timing information for long-running
  installer assemblies.
* Try to scope output of `Dist ...` to not also encompass actual build steps
@Centril Centril mentioned this pull request Sep 21, 2019
Merged
bors added a commit that referenced this pull request Sep 22, 2019
@bors
Auto merge of #64666 - Centril:rollup-tp98vlr, r=Centril
ef906d0 
Rollup of 9 pull requests

Successful merges:

 - #63907 (Add explanation to type mismatch involving type params and assoc types)
 - #64615 (rustbuild: Turn down compression on exe installers)
 - #64617 (rustbuild: Turn down compression on msi installers)
 - #64618 (rustbuild: Improve output of `dist` step)
 - #64619 (Fixes #63962. Hint about missing tuple parentheses in patterns)
 - #64634 (Update to LLVM 9.0.0)
 - #64635 (Allow using fn pointers in const fn with unleash miri)
 - #64660 (unify errors for tuple/struct variants)
 - #64664 (fully remove AstBuilder)

Failed merges:

r? @ghost
@bors bors merged commit 255dd3f into rust-lang:master Sep 22, 2019
@alexcrichton alexcrichton deleted the improve-dist-output branch September 23, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Awaiting requested review from Mark-Simulacrum

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @rust-highfive @Mark-Simulacrum @bors @nikomatsakis