Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use precalculated dominators in explain_borrow #65172

Merged
merged 1 commit into from
Oct 16, 2019
Merged

use precalculated dominators in explain_borrow #65172

merged 1 commit into from
Oct 16, 2019

Commits on Oct 6, 2019

  1. use precalculated dominators in explain_borrow 

    This looks like the only place calculating dominators from the MIR body every time instead of using the ones stored on the `MirBorrowckCtxt`. For example, in rust-lang#65131 a big generated function with a number of borrowck errors takes a few hours(!) recalculating the dominators while explaining the errors.

I don't know enough about this part of rustc codebase to know for sure that this change is correct, but no tests seem to fail as a result of this change in local testing.
    @tanriol
    tanriol committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    4cc707c View commit details
    Browse the repository at this point in the history