Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-nightly] Testing out rustc-dev #65453

Merged
merged 3 commits into from
Oct 16, 2019

Conversation

Mark-Simulacrum
Copy link
Member

This PR targets a non-official branch such that we can run full CI and eventually build a nightly from the branch on dev-static; this will hopefully allow us to iron out kinks prior to merging this PR's commits into master proper.

cc #64823 and #65337

cuviper and others added 3 commits October 15, 2019 18:38
This splits out a rustc-dev component with the compiler crates, and
keeps the status quo of default installed files on nightly. The default
changing to not install compiler libraries by default is left for a
future pull request.

However, on stable and beta, this does remove the compiler libraries
from the set of libraries installed by default, as they are never needed
there (per our stability story, they "cannot" be used).
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against to-be-dev-nightly. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2019
@Mark-Simulacrum
Copy link
Member Author

@bors rollup=never r+

This is per a conversation on Discord. We will "waste" a CI cycle on this but that's largely unavoidable. Self-approving as we are not merging into an official branch.

@bors
Copy link
Contributor

bors commented Oct 15, 2019

📌 Commit 7ccf492 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2019
@Mark-Simulacrum
Copy link
Member Author

@bors p=1

Since we would like to get these results sooner rather than later to enable testing and hopefully get the wins into beta at least.

@bors
Copy link
Contributor

bors commented Oct 16, 2019

⌛ Testing commit 7ccf492 with merge 5b416fb...

bors added a commit that referenced this pull request Oct 16, 2019
[dev-nightly] Testing out rustc-dev

This PR targets a non-official branch such that we can run full CI and eventually build a nightly from the branch on dev-static; this will hopefully allow us to iron out kinks prior to merging this PR's commits into master proper.

cc #64823 and #65337
@bors
Copy link
Contributor

bors commented Oct 16, 2019

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 5b416fb to to-be-dev-nightly...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 16, 2019
@bors bors merged commit 7ccf492 into rust-lang:to-be-dev-nightly Oct 16, 2019
@pietroalbini
Copy link
Member

Kicked off the release process on this.

@pietroalbini
Copy link
Member

Release available on dev-static.

@Mark-Simulacrum Mark-Simulacrum deleted the temp-nightly branch October 16, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants