Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify pattern-matching usefulness algorithm #65874

Merged
merged 17 commits into from
Nov 5, 2019

Commits on Oct 27, 2019

  1. Run rustfmt

    Nadrieril committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    a5de5a6 View commit details
    Browse the repository at this point in the history
  2. tidy

    Nadrieril committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    af35934 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7986599 View commit details
    Browse the repository at this point in the history
  4. Clarify and fix the explanation of the algorithm

    There was a bit of confusion between individual patterns and lists of
    patterns, and index mismatches linked to that. This introduces a
    vocabulary of "pattern-stacks" to provide a clearer mental model of what
    is happening. This also adds examples.
    Nadrieril committed Oct 27, 2019
    Configuration menu
    Copy the full SHA
    2665b64 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2019

  1. Configuration menu
    Copy the full SHA
    403d6bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23ca38e View commit details
    Browse the repository at this point in the history
  3. Remove some redundancy

    Nadrieril committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    5e734be View commit details
    Browse the repository at this point in the history
  4. Remove duplicate logic in compute_missing_constructors

    This is equivalent to the previous code in terms of performance. The
    expensive path is clearly identical. The fast path is also the same,
    because in both cases we loop until we get a non-empty `refined_ctors`,
    and then stop there. So the new code doesn't compute anything more
    than the previous did.
    Nadrieril committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    0c02c19 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b454581 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    175976e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    57a656a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d663c27 View commit details
    Browse the repository at this point in the history
  9. Wording

    Nadrieril committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    cc4583d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    92101b7 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b7fa9f1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8956c1e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a96d700 View commit details
    Browse the repository at this point in the history