Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CrateMetadata's source_map_import_info and dep_node_index fields private #66001

Closed
wants to merge 2 commits into from
Closed

Make CrateMetadata's source_map_import_info and dep_node_index fields private #66001

wants to merge 2 commits into from

Conversation

spastorino
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 31, 2019
@spastorino spastorino force-pushed the crate-metadata-impl-block branch 2 times, most recently from 8bd94d1 to 77b0c8b Compare October 31, 2019 16:09
@spastorino spastorino changed the title Crate metadata impl block Make CrateMetadata's source_map_import_info and dep_node_index fields private Oct 31, 2019
@petrochenkov petrochenkov self-assigned this Oct 31, 2019
@bors
Copy link
Contributor

bors commented Nov 1, 2019

☔ The latest upstream changes (presumably #65698) made this pull request unmergeable. Please resolve the merge conflicts.

This was referenced Nov 1, 2019
Closed
Closed
@petrochenkov
Copy link
Contributor

So, cstore_impl wants to use both data inherent to crates (CrateRoot) and data associated with crates when they are loaded into this specific session (CrateMetadata).
To keep things private, the former methods want to live in decoder.rs and the latter methods want to live in cstore.rs.

Perhaps we'll have to split the provide method into two parts and split the CrateStore trait into two traits to do that.

I've started with privatizing methods in decoder.rs and moving cstore_impls there in #66056.
Marking this PR as blocked on it for now.

@petrochenkov petrochenkov added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2019
@petrochenkov petrochenkov mentioned this pull request Nov 3, 2019
Merged
@bors
Copy link
Contributor

bors commented Nov 7, 2019

☔ The latest upstream changes (presumably #66180) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov
Copy link
Contributor

Superseded by #66496.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

@petrochenkov petrochenkov

Labels
S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spastorino @bors @petrochenkov @Mark-Simulacrum @rust-highfive