Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 7 pull requests #66578

Merged
merged 39 commits into from
Nov 20, 2019
Merged

Rollup of 7 pull requests #66578

merged 39 commits into from
Nov 20, 2019

Commits on Nov 3, 2019

  1. add header to compiletest to check for ice

    @traxys
    traxys committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    6299c33 View commit details
    Browse the repository at this point in the history

  2. add rustc_error(delay_span_bug_from_inside_query) attribute

    @traxys
    traxys committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    32f3fe7 View commit details
    Browse the repository at this point in the history

  3. remove another status code check is should-ice

    @traxys
    traxys committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    aa028cd View commit details
    Browse the repository at this point in the history

  4. added test for checking that ICEs are not hidden

    @traxys
    traxys committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    0f91ed4 View commit details
    Browse the repository at this point in the history

  5. tidy

    @traxys
    traxys committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    fff3c25 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. rewrote error messages for #[rustc_error]

    @traxys
    traxys committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    f0d2061 View commit details
    Browse the repository at this point in the history

  2. was not the same replace as others

    @traxys
    traxys committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    9305e60 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2019

  1. putting the failure_status code in header.rs

    @traxys
    traxys committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    5852a3f View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2019

  1. check for sould-ice either in compilefail or incremental cfail

    @traxys
    traxys committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    e01d941 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2019

  1. rustc_metadata: Move some structs from cstore to decoder 

    This allows to privatize their fields.
    @petrochenkov
    petrochenkov committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    68985c7 View commit details
    Browse the repository at this point in the history

  2. rustc_metadata: locator::Context -> CrateLocator

    @petrochenkov
    petrochenkov committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    c6bcf60 View commit details
    Browse the repository at this point in the history

  3. rustc_metadata: Give a constructor to CrateLocator

    @petrochenkov
    petrochenkov committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    bdce69d View commit details
    Browse the repository at this point in the history

  4. rustc_metadata: Give a constructor to CrateMetadata

    @petrochenkov
    petrochenkov committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    ff3e06f View commit details
    Browse the repository at this point in the history

  5. rustc_metadata: Minor cleanup

    @petrochenkov
    petrochenkov committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    0aed810 View commit details
    Browse the repository at this point in the history

  6. rustc_metadata: Give a constructor to CratePaths

    @petrochenkov
    petrochenkov committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    41ee980 View commit details
    Browse the repository at this point in the history

  7. rustc_metadata: Move CrateMetadata into decoder.rs 

    It allows to make most of its fields private
    @petrochenkov
    petrochenkov committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    c157023 View commit details
    Browse the repository at this point in the history

  8. rustc_metadata: Stop leaking Lazy from the rmeta module

    @petrochenkov
    petrochenkov committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    09c1c94 View commit details
    Browse the repository at this point in the history

  9. rustc_metadata: Remove CrateMetadata::is_proc_macro_crate

    @petrochenkov
    petrochenkov committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    26f113e View commit details
    Browse the repository at this point in the history

  10. rustc_metadata: Cleanup crate search with exact paths

    @petrochenkov
    petrochenkov committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    febde53 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. Fix selected crate search filter

    @GuillaumeGomez
    GuillaumeGomez committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    00ef5c1 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. Avoid ICE when breaking to an unreachable label

    @estebank
    estebank committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    31620fb View commit details
    Browse the repository at this point in the history

  2. Derive HashStable in librustc.

    @cjgillot
    cjgillot committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    e00ebd7 View commit details
    Browse the repository at this point in the history

  3. More HashStable.

    @cjgillot
    cjgillot committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    c4bc3f0 View commit details
    Browse the repository at this point in the history

  4. More HashStable.

    @cjgillot
    cjgillot committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    781866f View commit details
    Browse the repository at this point in the history

  5. Derive HashStable more.

    @cjgillot
    cjgillot committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    e1522fa View commit details
    Browse the repository at this point in the history

  6. Derive HashStable in librustc_mir.

    @cjgillot
    cjgillot committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    d9eaaf5 View commit details
    Browse the repository at this point in the history

  7. Fix project syntax.

    @cjgillot
    cjgillot committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    7db84e8 View commit details
    Browse the repository at this point in the history

  8. Fix derive syntax.

    @cjgillot
    cjgillot committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    4da5fe7 View commit details
    Browse the repository at this point in the history

  9. Revert expansion of impl HashStable for Frame.

    @cjgillot
    cjgillot committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    579625b View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. rustdoc: fixes rust-lang#64305: disable search field instead of hiddi… 

    …ng it

Signed-off-by: Maxime “pep” Buquet <[email protected]>
    @Ppjet6 @GuillaumeGomez
    Ppjet6 authored and GuillaumeGomez committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    5cbd406 View commit details
    Browse the repository at this point in the history

  2. Change background-color of search input if disabled

    @GuillaumeGomez
    GuillaumeGomez committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    5721338 View commit details
    Browse the repository at this point in the history

  3. Ignore run-make reproducible-build-2 on Mac (we already ignore it on … 

    …Windows).

Until we can dedicate resources to fixing this properly, I think we are
best off just ignoring this test on platforms/contexts where it does not
matter as much.
    @pnkfelix
    pnkfelix committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    6ab28b5 View commit details
    Browse the repository at this point in the history

  4. Rollup merge of rust-lang#66060 - traxys:test_65401, r=michaelwoerister 

    Making ICEs and test them in incremental

This adds:
 - A way to make the compiler ICE
 - A way to check for ICE in `cfail` tests with `should-ice`
 - A regression test for issue rust-lang#65401

I am not sure the attribute added `should-ice` is the best for this job
    @Centril
    Centril committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    e32397a View commit details
    Browse the repository at this point in the history

  5. Rollup merge of rust-lang#66298 - Ppjet6:disable-search-field, r=Guil… 

    …laumeGomez

rustdoc: fixes rust-lang#64305: disable search field instead of hidding it

The result seems to be ok but I wasn't entirely sure how to get there. I tried to stay generic a bit but maybe it's not required at all.

@GuillaumeGomez

Signed-off-by: Maxime “pep” Buquet <[email protected]>
    @Centril
    Centril committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    00cbc75 View commit details
    Browse the repository at this point in the history

  6. Rollup merge of rust-lang#66457 - cjgillot:just_hashstable, r=Zoxc 

    Just derive Hashstable in librustc

Split out of rust-lang#66279

r? @Zoxc
    @Centril
    Centril committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    647eda1 View commit details
    Browse the repository at this point in the history

  7. Rollup merge of rust-lang#66496 - petrochenkov:metapriv2, r=eddyb 

    rustc_metadata: Privatize more things

Continuation of rust-lang#66056.

The most notable change here is that `CrateMetadata` is moved from `cstore.rs` to `decoder.rs`.
Most of uses of `CrateMetadata` fields are in the decoder and uses of `root: CrateRoot` and other fields are so intertwined with each other that it would be hard to move a part of them into `cstore.rs` to privatize `CrateMetadata` fields, so we are going the other way round.

`cstore.rs` can probably be dismantled now, but I'll leave this to some other day.
Similarly, remaining `CrateMetadata` fields can be privatized by introducing some getter/setter methods, but not today.

r? @eddyb
    @Centril
    Centril committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    5a84f9b View commit details
    Browse the repository at this point in the history

  8. Rollup merge of rust-lang#66514 - GuillaumeGomez:fix-search-filter-sa… 

    …ve, r=kinnison

Fix selected crate search filter

Fixes rust-lang#62929.

r? @kinnison
    @Centril
    Centril committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    4bd9168 View commit details
    Browse the repository at this point in the history

  9. Rollup merge of rust-lang#66535 - estebank:issue-62480, r=matthewjasper 

    Avoid ICE when `break`ing to an unreachable label

Fix rust-lang#62480.
    @Centril
    Centril committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    52ed2c6 View commit details
    Browse the repository at this point in the history

  10. Rollup merge of rust-lang#66573 - pnkfelix:issue-66568-ignore-reprodu… 

    …cible-build-2-on-macos, r=alexcrichton

Ignore run-make reproducible-build-2 on Mac

Ignore run-make reproducible-build-2 on Mac (we already ignore it on Windows).

Until we can dedicate resources to fixing this properly, I think we are best off just ignoring this test on platforms/contexts where it does not matter as much.

cc rust-lang#66568
    @Centril
    Centril committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    8754409 View commit details
    Browse the repository at this point in the history