Allow customising ty::TraitRef's printing behavior #66613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
r? @eddyb, as they have better context on what's to be accomplished here. I am slightly surprised there's no user visible changes. |
|
Would you mind restarting the build? Or can I do it? |
|
To restart the build you can close and reopen the pr |
|
☔ The latest upstream changes (presumably #66686) made this pull request unmergeable. Please resolve the merge conflicts. |
basil-cow
force-pushed
the
trait-ref-print
branch
2 times, most recently
from
f5ecb51
to
be3bcb3
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Something went wrong when rebasing, I think it's connected to the fact that I unbeknownst to me updated clippy, I would appreciate any help. |
basil-cow
force-pushed
the
trait-ref-print
branch
from
be3bcb3
to
ac5e5cf
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
eddyb
reviewed
Nov 28, 2019
| @@ -401,15 +401,15 @@ impl NiceRegionError<'me, 'tcx> { | |||
| format!( | |||
| "{}`{}` would have to be implemented for the type `{}`", | |||
| if leading_ellipsis { "..." } else { "" }, | |||
| expected_trait_ref, | |||
| expected_trait_ref.map(ty::TraitRef::print_only_trait_path), | |||
There was a problem hiding this comment.
Isn't |tr| tr.print_only_trait_path() shorter?
eddyb
reviewed
Nov 28, 2019
| @@ -1292,7 +1292,7 @@ impl<'a, 'tcx> InferCtxt<'a, 'tcx> { | |||
| } | |||
|
|
|||
| pub fn trait_ref_to_string(&self, t: &ty::TraitRef<'tcx>) -> String { | |||
| self.resolve_vars_if_possible(t).to_string() | |||
| self.resolve_vars_if_possible(t).print_only_trait_path().to_string() | |||
| } | |||
There was a problem hiding this comment.
I find it a bit odd that this method exists, I wonder where it's used. (not relevant to this PR though)
eddyb
approved these changes
Nov 28, 2019
basil-cow
force-pushed
the
trait-ref-print
branch
from
6f2493d
to
4611554
Compare
|
☔ The latest upstream changes (presumably #66567) made this pull request unmergeable. Please resolve the merge conflicts. |
basil-cow
force-pushed
the
trait-ref-print
branch
from
4611554
to
b085973
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@Areredify Btw, if you use |
|
Why is this even happening? Do I need to do a |
fix clippy allow customising ty::TraitRef's printing behavior fix clippy stylistic fix
basil-cow
force-pushed
the
trait-ref-print
branch
from
b085973
to
f07bd06
Compare
|
@Areredify I'm not sure, the only way I can think of to find out is to never use Note that running |
eddyb
approved these changes
Nov 29, 2019
|
@bors r+ |
|
📌 Commit f07bd06 has been approved by |
bors
added
S-waiting-on-bors
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Nov 29, 2019
Allow customising ty::TraitRef's printing behavior This pr allows to explicitly choose which representation of `TraitRef` (`<T as Trait<U>>` or `Trait<U>`) you want to print. `Debug` and `Display` representations of `TraitRef` now match. Closes rust-lang#59188.
bors
added a commit
that referenced
this pull request
Nov 29, 2019
Allow customising ty::TraitRef's printing behavior This pr allows to explicitly choose which representation of `TraitRef` (`<T as Trait<U>>` or `Trait<U>`) you want to print. `Debug` and `Display` representations of `TraitRef` now match. Closes #59188.
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Nov 29, 2019
Allow customising ty::TraitRef's printing behavior This pr allows to explicitly choose which representation of `TraitRef` (`<T as Trait<U>>` or `Trait<U>`) you want to print. `Debug` and `Display` representations of `TraitRef` now match. Closes rust-lang#59188.
|
@bors retry rolled up |
bors
added a commit
that referenced
this pull request
Nov 29, 2019
Rollup of 11 pull requests Successful merges: - #66379 (Rephrase docs in for ptr) - #66589 (Draw vertical lines correctly in compiler error messages) - #66613 (Allow customising ty::TraitRef's printing behavior) - #66766 (Panic machinery comments and tweaks) - #66791 (Handle GlobalCtxt directly from librustc_interface query system) - #66793 (Record temporary static references in generator witnesses) - #66808 (Cleanup error code) - #66826 (Clarifies how to tag users for assigning PRs) - #66837 (Clarify `{f32,f64}::EPSILON` docs) - #66844 (Miri: do not consider memory allocated by caller_location leaked) - #66872 (Minor documentation fix) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr allows to explicitly choose which representation of
TraitRef(<T as Trait<U>>orTrait<U>) you want to print.DebugandDisplayrepresentations ofTraitRefnow match.Closes #59188.