Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove irelevant comment on register_dtor #67230

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Remove irelevant comment on register_dtor #67230

merged 1 commit into from
Dec 12, 2019

Conversation

chansuke
Copy link
Contributor

Fixes #66572.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 11, 2019
@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 11, 2019

📌 Commit e4852da has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Dec 12, 2019
@JohnTitor
Rollup merge of rust-lang#67230 - chansuke:remove-irrelevant-passage,…
3cf7996 
… r=Dylan-DPC

Remove irelevant comment on `register_dtor`

Fixes rust-lang#66572.
@JohnTitor JohnTitor mentioned this pull request Dec 12, 2019
Merged
bors added a commit that referenced this pull request Dec 12, 2019
@bors
Auto merge of #67246 - JohnTitor:rollup-nfa7skn, r=JohnTitor
f284f8b 
Rollup of 8 pull requests

Successful merges:

 - #62514 (Clarify `Box<T>` representation and its use in FFI)
 - #66983 (Fix `unused_parens` triggers on macro by example code)
 - #67215 (Fix `-Z print-type-sizes`'s handling of zero-sized fields.)
 - #67230 (Remove irelevant comment on `register_dtor`)
 - #67236 (resolve: Always resolve visibilities on impl items)
 - #67237 (Some small readability improvements)
 - #67238 (Small std::borrow::Cow improvements)
 - #67239 (Make TinyList::remove iterate instead of recurse)

Failed merges:

r? @ghost
@bors bors merged commit e4852da into rust-lang:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is the generic passage on register_dtor still relevant?
5 participants
@chansuke @rust-highfive @Dylan-DPC-zz @bors @alexcrichton