Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak non_shorthand_field_patterns' suggestion #67500

Merged
merged 1 commit into from
Dec 22, 2019

Conversation

JohnTitor
Copy link
Member

Fixes #66434

r? @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 21, 2019
@Centril
Copy link
Contributor

Centril commented Dec 21, 2019

r? @Centril @bors r+

@bors
Copy link
Contributor

bors commented Dec 21, 2019

📌 Commit 30e84b0 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned estebank Dec 21, 2019
@bors
Copy link
Contributor

bors commented Dec 21, 2019

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2019
Centril added a commit to Centril/rust that referenced this pull request Dec 22, 2019
…rns, r=Centril

Tweak non_shorthand_field_patterns' suggestion

Fixes rust-lang#66434

r? @estebank
Centril added a commit to Centril/rust that referenced this pull request Dec 22, 2019
…rns, r=Centril

Tweak non_shorthand_field_patterns' suggestion

Fixes rust-lang#66434

r? @estebank
bors added a commit that referenced this pull request Dec 22, 2019
Rollup of 6 pull requests

Successful merges:

 - #67148 ( Refactor type & bounds parsing thoroughly)
 - #67410 (Reenable static linking of libstdc++ on windows-gnu)
 - #67439 (Cleanup `lower_pattern_unadjusted` & Improve slice pat typeck)
 - #67480 (Require issue = "none" over issue = "0" in unstable attributes)
 - #67500 (Tweak non_shorthand_field_patterns' suggestion)
 - #67504 (Warn against relying on ?Sized being last)

Failed merges:

r? @ghost
@bors bors merged commit 30e84b0 into rust-lang:master Dec 22, 2019
@JohnTitor JohnTitor deleted the non-shorthand-field-patterns branch December 22, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo fix fails on non_shorthand_field_patterns
5 participants