Generalize array_into_iter lint to also lint for boxed arrays
#67524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Dec 22, 2019
tesuji
reviewed
Dec 22, 2019
LukasKalbertodt
force-pushed
the
improve-into-iter-lint
branch
from
9089ac3
to
566c4c2
Compare
`Box` is special in that a method call on a box can move the value out of the box. Thus, the same backwards-compatibility problem can arise for boxed arrays as for simple arrays.
LukasKalbertodt
force-pushed
the
improve-into-iter-lint
branch
from
566c4c2
to
f934b83
Compare
|
@bors r+ |
|
📌 Commit f934b83 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 25, 2019
…hewjasper Generalize `array_into_iter` lint to also lint for boxed arrays `Box` is special in that a method call on a box can move the value out of the box. Thus, the same backwards-compatibility problem can arise for boxed arrays as for simple arrays. --- CC #66145 r? @matthewjasper (as you reviewed the first PR)
|
☀️ Test successful - checks-azure |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boxis special in that a method call on a box can move the value outof the box. Thus, the same backwards-compatibility problem can arise
for boxed arrays as for simple arrays.
CC #66145
r? @matthewjasper (as you reviewed the first PR)