Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup err codes #67547

Merged
merged 3 commits into from
Dec 24, 2019
Merged

Cleanup err codes #67547

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ee18c9
Clean up E0124 explanation
GuillaumeGomez Dec 22, 2019
1474d2a
Clean up E0128 explanation
GuillaumeGomez Dec 22, 2019
256eec4
Update E0124.md
Dylan-DPC Dec 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/librustc_error_codes/error_codes/E0124.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
You declared two fields of a struct with the same name. Erroneous code
example:
A struct with two fields having the same name has been declared.
Dylan-DPC-zz marked this conversation as resolved.
Show resolved Hide resolved

Erroneous code example:

```compile_fail,E0124
struct Foo {
Expand Down
9 changes: 5 additions & 4 deletions src/librustc_error_codes/error_codes/E0128.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Type parameter defaults can only use parameters that occur before them.
A type parameter with default value is using forward declared identifier.

Erroneous code example:

```compile_fail,E0128
Expand All @@ -7,11 +8,11 @@ struct Foo<T = U, U = ()> {
field2: U,
}
// error: type parameters with a default cannot use forward declared
// identifiers
// identifiers
```

Since type parameters are evaluated in-order, you may be able to fix this issue
by doing:
Type parameter defaults can only use parameters that occur before them. Since
type parameters are evaluated in-order, this issue could be fixed by doing:

```
struct Foo<U = (), T = U> {
Expand Down