Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest to shorten temporary borrow from raw pointer #68269

Merged
merged 2 commits into from
Jan 25, 2020
Merged

Suggest to shorten temporary borrow from raw pointer #68269

merged 2 commits into from
Jan 25, 2020

Conversation

csmoe
Copy link
Member

@csmoe csmoe commented Jan 16, 2020

Closes #65436
r? @estebank
cc @tmandry

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 16, 2020
@rust-highfive

This comment has been minimized.

Sign in to view
estebank
estebank reviewed Jan 16, 2020
View reviewed changes
src/librustc/traits/error_reporting.rs Outdated Show resolved Hide resolved
src/librustc/traits/error_reporting.rs Outdated Show resolved Hide resolved
@rust-highfive

This comment has been minimized.

Sign in to view
@yshui
Copy link
Contributor

yshui commented Jan 17, 2020

#65436 is about general !Send types, yet this PR seems (IIUC) to just cover just raw pointer. Could this PR really close #65436?

i.e. https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=e7538e93bf6ee4a748410a86d21ce0d7

@yshui yshui mentioned this pull request Jan 17, 2020
Closed
@bors
Copy link
Contributor

bors commented Jan 17, 2020

☔ The latest upstream changes (presumably #68305) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank
Copy link
Contributor

r=me after rebase

@tmandry
Copy link
Member

tmandry commented Jan 18, 2020

#65436 is about general !Send types, yet this PR seems (IIUC) to just cover just raw pointer. Could this PR really close #65436?

I agree it would be nice to generalize this (maybe in a future PR) to all !Send types. I don't know how difficult that would be, though.

@rust-highfive

This comment has been minimized.

Sign in to view
@csmoe
Copy link
Member Author

csmoe commented Jan 19, 2020

r? @estebank

@csmoe
Copy link
Member Author

csmoe commented Jan 23, 2020 •
edited
Loading

@estebank ping

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 25, 2020

📌 Commit cd7b5ed has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2020
@bors
Copy link
Contributor

bors commented Jan 25, 2020

⌛ Testing commit cd7b5ed with merge 8bf1758...

bors added a commit that referenced this pull request Jan 25, 2020
@bors
Auto merge of #68269 - csmoe:temp, r=estebank
8bf1758 
Suggest to shorten temporary borrow from raw pointer

Closes #65436
r? @estebank
cc @tmandry
@bors
Copy link
Contributor

bors commented Jan 25, 2020

☀️ Test successful - checks-azure
Approved by: estebank
Pushing 8bf1758 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 25, 2020
@bors bors merged commit cd7b5ed into rust-lang:master Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

@estebank estebank estebank left review comments

@tmandry tmandry tmandry left review comments

Assignees

@estebank estebank

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

async/await regression regarding borrows across yields
7 participants
@csmoe @rust-highfive @yshui @bors @estebank @tmandry @Centril