Clean up E0198 explanation #68279
Merged
Clean up E0198 explanation #68279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Dylan-DPC-zz
suggested changes
Jan 16, 2020
| particular trait. Not being able to use a trait is always a safe operation, | ||
| so negative implementations are always safe and never need to be marked as | ||
| unsafe. | ||
| A negative implementation was marked as being unsafe. |
There was a problem hiding this comment.
Suggested change
| A negative implementation was marked as being unsafe. | |
| A negative implementation was marked as unsafe. |
|
Updated! |
GuillaumeGomez
force-pushed
the
clean-up-e0198
branch
from
81662d0
to
9c6c2f1
Compare
|
@bors r+ rollup |
|
📌 Commit 9c6c2f1 has been approved by |
bors
added
S-waiting-on-bors
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Jan 17, 2020
…lan-DPC Clean up E0198 explanation r? @Dylan-DPC
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Jan 18, 2020
…lan-DPC Clean up E0198 explanation r? @Dylan-DPC
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Jan 18, 2020
…lan-DPC Clean up E0198 explanation r? @Dylan-DPC
bors
added a commit
that referenced
this pull request
Jan 18, 2020
Rollup of 9 pull requests Successful merges: - #66660 (Don't warn about snake case for field puns.) - #68093 (Fix deref impl typedef) - #68204 (Use named fields for `{ast,hir}::ItemKind::Impl`) - #68256 (Do not ICE on malformed suggestion spans) - #68279 (Clean up E0198 explanation) - #68291 (Update sanitizer tests) - #68312 (Add regression test for integer literals in generic arguments in where clauses) - #68314 (Stop treating `FalseEdges` and `FalseUnwind` as having semantic value for const eval) - #68317 (Clean up E0199 explanation) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Dylan-DPC