Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator Resume Arguments #68524

Merged
merged 25 commits into from
Feb 7, 2020
Merged

Generator Resume Arguments #68524

merged 25 commits into from
Feb 7, 2020

Commits on Feb 2, 2020

  1. Add a resume type parameter to Generator

    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    044fe0f View commit details
    Browse the repository at this point in the history

  2. Add a resume type param to the generator substs 

    ...and unify it with `()` for now
    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    0117033 View commit details
    Browse the repository at this point in the history

  3. Use real resume type as second argument

    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    25af2f6 View commit details
    Browse the repository at this point in the history

  4. Infer type of yield to be resume type

    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    8a1227a View commit details
    Browse the repository at this point in the history

  5. Allow 0 or 1 explicit generator parameters

    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    32005fe View commit details
    Browse the repository at this point in the history

  6. Adjust tests to type inference changes 

    This makes some error messages ungreat, but those seem to be preexisting
bugs that also apply to closures / return position `impl Trait` in
general.
    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    2101a1f View commit details
    Browse the repository at this point in the history

  7. Add resume arg place to Yield MIR terminator

    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    f2c1468 View commit details
    Browse the repository at this point in the history

  8. Change MIR building to fill in the resume place 

    This changes `Yield` from `as_rvalue` to `into` lowering, which could
have a possible performance impact. I could imagine special-casing
some resume types here to use a simpler lowering for them, but it's
unclear if that makes sense at this stage.
    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    3c069a0 View commit details
    Browse the repository at this point in the history

  9. Make generator transform move resume arg around 

    The resume arg is passed as argument `_2` and needs to be moved to the
`Yield`s target `Place`
    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    3c22e51 View commit details
    Browse the repository at this point in the history

  10. Fix error message on type mismatch in generator 

    Instead of "closure is expected to take 0 arguments"
we now get the expected type mismatch error.
    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    5b2059b View commit details
    Browse the repository at this point in the history

  11. Add tests for generator resume arguments

    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    fca614e View commit details
    Browse the repository at this point in the history

  12. Add test for E0628 (too many generator parameters)

    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    4ee857c View commit details
    Browse the repository at this point in the history

  13. Fix bootstrap rustc build

    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    7a9709b View commit details
    Browse the repository at this point in the history

  14. Adjust mir-opt tests to new yield lowering

    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    3bb8ecb View commit details
    Browse the repository at this point in the history

  15. No resume argument in the drop shim

    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    aae0f54 View commit details
    Browse the repository at this point in the history

  16. Teach dropck about resume arguments

    @jonas-schievink
    jonas-schievink committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    9fa46fe View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2020

  1. Fix miscompilation

    @jonas-schievink
    jonas-schievink committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    392e595 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2020

  1. Add more tests for generator resume arguments

    @jonas-schievink
    jonas-schievink committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    341eaf5 View commit details
    Browse the repository at this point in the history

  2. Update error message with too many parameters

    @jonas-schievink
    jonas-schievink committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    cc66d29 View commit details
    Browse the repository at this point in the history

  3. Remove obsolete test

    @jonas-schievink
    jonas-schievink committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    72776e6 View commit details
    Browse the repository at this point in the history

  4. Take resume argument from the right generator type 

    I suppose we could also just put `tcx.mk_unit()` here, but this
works too
    @jonas-schievink
    jonas-schievink committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    895aab2 View commit details
    Browse the repository at this point in the history

  5. Don't emit StorageDead for the resume argument

    @jonas-schievink
    jonas-schievink committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    fb66b9e View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Simplify implicit resume argument

    @jonas-schievink
    jonas-schievink committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    84dd07a View commit details
    Browse the repository at this point in the history

  2. Clarify comment about _2 living across a yield

    @jonas-schievink
    jonas-schievink committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    732913a View commit details
    Browse the repository at this point in the history

  3. Ignore panic-drops-resume.rs on wasm/emscripten 

    It does not have unwinding support
    @jonas-schievink
    jonas-schievink committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    9d7b214 View commit details
    Browse the repository at this point in the history