-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse & reject postfix operators after casts #68985
Merged
Merged
Commits on Feb 16, 2020
-
Parse & reject postfix operators after casts
This adds parsing for expressions like 'x as Ty[0]' which will immediately error out, but still give the rest of the parser a valid parse tree to continue.
Configuration menu - View commit details
-
Copy full SHA for 940f657 - Browse repository at this point
Copy the full SHA 940f657View commit details -
Refactor out error case & apply suggestions.
This is almost entirely refactoring and message changing, with the single behavioral change of panicking for unexpected output.
Configuration menu - View commit details
-
Copy full SHA for 5ce9b80 - Browse repository at this point
Copy the full SHA 5ce9b80View commit details -
Type ascription outputs a Type, not Cast
Previously this just errored out on all usages of type ascription, which isn't helpful.
Configuration menu - View commit details
-
Copy full SHA for 4fc0532 - Browse repository at this point
Copy the full SHA 4fc0532View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cf2049 - Browse repository at this point
Copy the full SHA 0cf2049View commit details -
Configuration menu - View commit details
-
Copy full SHA for f82ca8b - Browse repository at this point
Copy the full SHA f82ca8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dd6464 - Browse repository at this point
Copy the full SHA 5dd6464View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3eefe2 - Browse repository at this point
Copy the full SHA e3eefe2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2d7ffb - Browse repository at this point
Copy the full SHA c2d7ffbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ef3da0 - Browse repository at this point
Copy the full SHA 8ef3da0View commit details
Commits on Feb 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for fa1f547 - Browse repository at this point
Copy the full SHA fa1f547View commit details -
This is a modified version of estebank's suggestion, with a bit of extra cleanup now that we don't need the different cases for if we can turn a span into a string or not.
Configuration menu - View commit details
-
Copy full SHA for f434c6e - Browse repository at this point
Copy the full SHA f434c6eView commit details
Commits on Feb 29, 2020
-
Replace ptr hashing with ptr casting
Implementes suggeseted changes by Centril. This checks whether the memory location of the cast remains the same after atttempting to parse a postfix operator after a cast has been parsed. If the address is not the same, an illegal postfix operator was parsed. Previously the code generated a hash of the pointer, which was overly complex and inefficent. Casting the pointers and comparing them is simpler and more effcient.
Configuration menu - View commit details
-
Copy full SHA for 453c505 - Browse repository at this point
Copy the full SHA 453c505View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.