Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ping the infrastructure team on toolstate changes #69336

Merged
merged 1 commit into from
Feb 23, 2020
Merged

Do not ping the infrastructure team on toolstate changes #69336

merged 1 commit into from
Feb 23, 2020

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Feb 21, 2020 •
edited
Loading

To my knowledge, there is essentially never any particular action that the infra team needs to take on these pings, and they are currently relatively annoying.

cc rust-lang/infra -- does anyone want these notifications?

@Mark-Simulacrum
Do not ping the infrastructure team on toolstate changes
e7ee42b 
To my knowledge, there is essentially never any particular action that the
infra team needs to take on these pings, and they are currently relatively
annoying.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 21, 2020
@Dylan-DPC-zz
Copy link

@bors r+

@bors
Copy link
Contributor

bors commented Feb 21, 2020

📌 Commit e7ee42b has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2020
@Mark-Simulacrum
Copy link
Member Author

@bors r-

I specifically want to give some time for infra to chime in.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 21, 2020
@bjorn3
Copy link
Member

bjorn3 commented Feb 21, 2020

cc rust-lang/infra -- does anyone want these notifications?

You seem to have omitted the @.

@kennytm kennytm added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 21, 2020
@kennytm
Copy link
Member

kennytm commented Feb 21, 2020

Perhaps:

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Feb 21, 2020 •
edited by shepmaster
Loading

Team member @kennytm has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Feb 21, 2020
@Mark-Simulacrum
Copy link
Member Author

I intentionally edited to remove the mention because bors includes the PR description in commits, and I didn't want to ping everyone lots of times needlessly.

Thanks for kicking off FCP, that's a good idea!

@shepmaster
Copy link
Member

As my own personal thing, I sometimes like those notifications because it means something interesting was merged. Other times it's not. Too bad there's no "would be magically interesting" filter 😉

@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Feb 21, 2020
@rfcbot
Copy link

rfcbot commented Feb 21, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Feb 21, 2020
@Mark-Simulacrum
Copy link
Member Author

@bors r=Dylan-DPC I guess, no need to wait for FCP I think. We can always revert, and I'm getting sufficiently annoyed at this filling up my triagebot notifications with noise :)

@bors
Copy link
Contributor

bors commented Feb 23, 2020

📌 Commit e7ee42b has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Feb 23, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 23, 2020
@Dylan-DPC
Rollup merge of rust-lang#69336 - Mark-Simulacrum:no-infra-toolstate,…
b760994 
… r=Dylan-DPC

Do not ping the infrastructure team on toolstate changes

To my knowledge, there is essentially never any particular action that the infra team needs to take on these pings, and they are currently relatively annoying.

cc rust-lang/infra -- does anyone *want* these notifications?
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 23, 2020
Merged
@bors
Copy link
Contributor

bors commented Feb 23, 2020

⌛ Testing commit e7ee42b with merge 9c230f3...

@bors
Copy link
Contributor

bors commented Feb 23, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing 9c230f3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 23, 2020
@bors bors merged commit 9c230f3 into rust-lang:master Feb 23, 2020
bors added a commit that referenced this pull request Feb 23, 2020
@bors
Auto merge of #69393 - Dylan-DPC:rollup-rxbd1zg, r=Dylan-DPC
6d0e58b 
Rollup of 5 pull requests

Successful merges:

 - #69336 (Do not ping the infrastructure team on toolstate changes)
 - #69351 (Improve external MinGW detection)
 - #69361 (parse: allow `type Foo: Ord` syntactically)
 - #69375 (Rename CodeMap to SourceMap follow up)
 - #69376 (parser: Cleanup `Parser::bump_with` and its uses)

Failed merges:

r? @ghost
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pietroalbini pietroalbini

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Mark-Simulacrum @Dylan-DPC-zz @bors @bjorn3 @kennytm @rfcbot @shepmaster @pietroalbini @rust-highfive