Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use .to_string() instead of format!() macro to create strings #69567

Merged
merged 1 commit into from
Feb 29, 2020

Conversation

matthiaskrgr
Copy link
Member

handles what is left after #69541

@rust-highfive
Copy link
Collaborator

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 28, 2020
src/librustc_lint/types.rs Outdated Show resolved Hide resolved
src/librustc_parse/parser/pat.rs Outdated Show resolved Hide resolved
@matthiaskrgr
Copy link
Member Author

@bors rollup

@bors
Copy link
Contributor

bors commented Feb 29, 2020

@matthiaskrgr: 🔑 Insufficient privileges: not in try users

@nagisa
Copy link
Member

nagisa commented Feb 29, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 29, 2020

📌 Commit 85e59b7 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 29, 2020
bors added a commit that referenced this pull request Feb 29, 2020
Rollup of 6 pull requests

Successful merges:

 - #69477 (docs: add mention of async blocks in move keyword docs)
 - #69504 (Use assert_ne in hash tests)
 - #69546 (use to_vec() instead of .iter().cloned().collect() to convert slices to vecs.)
 - #69551 (use is_empty() instead of len() == x  to determine if structs are empty.)
 - #69563 (Fix no_std detection for target triples)
 - #69567 (use .to_string() instead of format!() macro to create strings)

Failed merges:

r? @ghost
@bors bors merged commit bbfec7c into rust-lang:master Feb 29, 2020
@matthiaskrgr matthiaskrgr deleted the useless_fmt branch February 29, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants