Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #69612

Merged
merged 16 commits into from
Mar 1, 2020
Merged

Rollup of 7 pull requests #69612

merged 16 commits into from
Mar 1, 2020

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

JOE1994 and others added 16 commits February 28, 2020 19:28
1. Clarified on what should implement 'Clone' trait.
2. Minor grammar fix:
to be able clone => to be able to clone
Following suggestion from @jonas-schievink

Co-Authored-By: Jonas Schievink <[email protected]>
Removed trailing whitespace which caused to fail pretty-check
As `--crate-version` accepts arbitrary strings they need to be escaped.
…LukasKalbertodt

Use assert_ne in hash tests

The hash tests were written before the assert_ne macro was added to the standard library. The assert_ne macro provides better output in case of a failure.
Clarify explanation of Vec<T> 'fn resize'

1. Clarified on what should implement `Clone` trait.
2. Minor grammar fix:
to be able clone => to be able **to** clone
…k-Simulacrum

simplify boolean expressions
…e, r=GuillaumeGomez

rustdoc: HTML escape crate version

As `--crate-version` accepts arbitrary strings they need to be escaped.

r? @GuillaumeGomez
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=7

@bors
Copy link
Contributor

bors commented Mar 1, 2020

📌 Commit d3a5a5d has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 1, 2020
@Dylan-DPC-zz Dylan-DPC-zz added the rollup A PR which is a rollup label Mar 1, 2020
@bors
Copy link
Contributor

bors commented Mar 1, 2020

⌛ Testing commit d3a5a5d with merge beac68a...

@bors
Copy link
Contributor

bors commented Mar 1, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing beac68a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 1, 2020
@bors bors merged commit beac68a into rust-lang:master Mar 1, 2020
@bors bors mentioned this pull request Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants